Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feature parity for Vector2i with Godot #978

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

fpdotmonkey
Copy link
Contributor

This implements all remaining functions for Vector2i that Godot has, with a couple intentional exceptions. float scalar arithmetic won't be added because in Rust one should be explicit about int/float conversions. The AXIS_X and AXIS_Y constant also won't be added as they are shared with Vector2.

This is a part of the December 2024 gdext Mini Hackathon.

This implements all remaining functions for Vector2i that Godot has,
with a couple intentional exceptions.  float scalar arithmetic won't be
added because in Rust one should be explicit about int/float
conversions.  The `AXIS_X` and `AXIS_Y` constant also won't be added as
they are shared with `Vector2`.

This is a part of the December 2024 gdext Mini Hackathon.
@fpdotmonkey fpdotmonkey force-pushed the vector2i-compatibility branch from 2958cef to 435f586 Compare December 17, 2024 20:27
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-978

1 similar comment
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-978

@Bromeon Bromeon added feature Adds functionality to the library c: core Core components labels Dec 17, 2024
@Bromeon Bromeon added this pull request to the merge queue Dec 17, 2024
@Bromeon
Copy link
Member

Bromeon commented Dec 17, 2024

Thanks!

@Bromeon Bromeon changed the title Provide feature parity for Vector2i with Godot Provide feature parity for Vector2i with Godot Dec 17, 2024
Merged via the queue into godot-rust:master with commit c8ba45d Dec 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: core Core components feature Adds functionality to the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants