Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #[godot_dyn] causing error when implemented for two traits #962

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

0x53A
Copy link
Contributor

@0x53A 0x53A commented Dec 5, 2024

image

@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-962

@0x53A 0x53A force-pushed the dev-test-godot_dyn branch from addc355 to c96f333 Compare December 5, 2024 00:38
@Bromeon Bromeon added c: core Core components bug labels Dec 6, 2024
Also refine test slightly, to use fewer registered classes.
@Bromeon Bromeon changed the title [itest] add a test that checks if one Class can implement two traits via #[godot_dyn] Fix #[godot_dyn] causing error when implemented for two traits Dec 6, 2024
@Bromeon Bromeon added this pull request to the merge queue Dec 6, 2024
@Bromeon
Copy link
Member

Bromeon commented Dec 6, 2024

Good catch, thanks!

Merged via the queue into godot-rust:master with commit 032af6e Dec 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: core Core components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants