Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[class] attribute: rename hidden -> internal, deprecate editor_plugin #884

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Sep 3, 2024

The attribute key #[class(editor_plugin)] is now implied by #[class(base = EditorPlugin)].
Specifying it will no longer have an effect and raise a warning.

The attribute key #[class(hidden)] is renamed to #[class(internal)], following Godot terminology.
Specifying it will remain possible, with deprecation warning.

@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: register Register classes, functions and other symbols to GDScript labels Sep 3, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-884

@Bromeon Bromeon force-pushed the qol/redundant-class-attrs branch from 43e0a03 to ef6880b Compare September 3, 2024 17:12
@Bromeon Bromeon force-pushed the qol/redundant-class-attrs branch from ef6880b to 773e42e Compare September 3, 2024 17:21
@Bromeon Bromeon enabled auto-merge September 3, 2024 17:23
@Bromeon Bromeon added this pull request to the merge queue Sep 3, 2024
Merged via the queue into master with commit affb64d Sep 3, 2024
15 checks passed
@Bromeon Bromeon deleted the qol/redundant-class-attrs branch September 3, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: register Register classes, functions and other symbols to GDScript quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants