Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow Export if class doesn't inherit Node or Resource #839

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Disallow Export if class doesn't inherit Node or Resource #839

merged 2 commits into from
Aug 5, 2024

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Aug 4, 2024

This adopts the GDScript error message:

SCRIPT ERROR: Parse Error: Export type can only be built-in, a resource, a node, or an enum.

Also includes a very late addition of Var + Export for Variant, which seemingly no one needed 🙂

@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: register Register classes, functions and other symbols to GDScript breaking-change Requires SemVer bump labels Aug 4, 2024
@Bromeon Bromeon force-pushed the qol/export-restrictions branch from a70c030 to 94e20af Compare August 4, 2024 21:56
@Bromeon Bromeon added this pull request to the merge queue Aug 5, 2024
Merged via the queue into master with commit 6101ea0 Aug 5, 2024
14 checks passed
@Bromeon Bromeon deleted the qol/export-restrictions branch August 5, 2024 08:15
This was referenced Aug 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Requires SemVer bump c: register Register classes, functions and other symbols to GDScript quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Bromeon