Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ex* builder parameters: ObjectArg<T> -> impl AsObjectArg<T> #830

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Aug 2, 2024

Follow-up to #800 -- fixes incorrect codegen:

image

ObjectArg<T> is not part of the public API, so impl AsObjectArg<T> should be used instead.

@Bromeon Bromeon added bug c: engine Godot classes (nodes, resources, ...) labels Aug 2, 2024
@Bromeon Bromeon force-pushed the bugfix/default-params-object-arg branch from ed6ff78 to dd48d2d Compare August 2, 2024 09:35
@Bromeon Bromeon enabled auto-merge August 2, 2024 09:39
@Bromeon Bromeon added this pull request to the merge queue Aug 2, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-830

Merged via the queue into master with commit 7dc50e5 Aug 2, 2024
14 checks passed
@Bromeon Bromeon deleted the bugfix/default-params-object-arg branch August 2, 2024 09:46
@godot-rust godot-rust deleted a comment from GodotRust Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: engine Godot classes (nodes, resources, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants