Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer is already *const u32 on aarch64 #788

Merged

Conversation

TitanNano
Copy link
Contributor

On macOS aaarch64 clippy complains that ptris already of type *const u32, making the cast redundant.

@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-788

@Bromeon Bromeon added the bug label Jul 8, 2024
@Bromeon
Copy link
Member

Bromeon commented Jul 8, 2024

Thank you! This part of the code has caused so many issues already... I should accelerate the deletion of platform-specific instructions, as only Godot 4.0 benefits from the validity check.

@Bromeon Bromeon added this pull request to the merge queue Jul 8, 2024
@Bromeon Bromeon added the c: core Core components label Jul 8, 2024
Merged via the queue into godot-rust:master with commit 88716c7 Jul 8, 2024
15 checks passed
@TitanNano TitanNano deleted the jovan/unnecessary_pointer_cast branch July 8, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: core Core components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants