Massive refactor: split codegen into JSON and domain models #573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of issues in
godot-codegen
have arisen because all business logic (analyzing symbols, generating code, ...) was operating on the raw JSON models from the extension API. While this worked well in the beginning, it caused more and more issues over time and became a scalability hazard:Option<Vec<T>>
instead ofVec<T>
).This is the foundation for more codegen cleanups and is direly needed for some of the features I plan to implement soon.