Implement builtin type Signal
#570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1727db to
ef0d2b5
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
ef0d2b5 to
c8b2e98
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-570 |
6cd5e3c to
62565d0
Compare
|
@Bromeon I'm not quite sure what is going on with the crash in 4.0 |
Bromeon
reviewed
Jan 20, 2024
There was a problem hiding this comment.
Thanks a lot!
Regarding the crash, it seems test_varcall_signal fails. It may need more debugging, but from a distance, it could be that the conversion between Variant and Signal is not correctly implemented for Godot 4.0.
Maybe you could add tests in variant_conversions() (variant_test.rs) for signals -- and see if those pass or not? Feel free to use #[itest(focus)].
d5b8da6 to
141590d
Compare
141590d to
f90ba67
Compare
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the built-in type
Signal.The implementation is heavily based on the already present
Callabletype.