Rework integration tests: self-registering #[itest], Rust runner
#142
+426
−474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More uniform codebase, static typing, faster test execution.
tryBuild succeeded: |
# Conflicts: # itest/rust/src/lib.rs # itest/rust/src/variant_test.rs
1c6a830 to
5d6218f
Compare
|
bors r+ |
|
Build succeeded: |
hydrolarus
reviewed
Mar 5, 2023
| @@ -148,6 +149,32 @@ pub fn default_call_error() -> GDExtensionCallError { | |||
| } | |||
| } | |||
|
|
|||
| #[doc(hidden)] | |||
| #[inline] | |||
| pub fn panic_on_call_error(err: &GDExtensionCallError) { | |||
There was a problem hiding this comment.
a little late, but this seems like a great candidate for using #[track_caller], doesn't it?
There was a problem hiding this comment.
This is great advice, thanks! I was actually considering to make it a macro for this very reason, but totally forgot about this attribute 👍
No worries about "late", 2nd round of test improvements already on the way 😎
There was a problem hiding this comment.
I just tested it btw, indeed it works and shows the occurrence of the panic (with RUST_BACKTRACE=0) on the call site.
bors bot
added a commit
that referenced
this pull request
Mar 6, 2023
146: `#[itest(skip)]` + `#[itest(focus)]` r=Bromeon a=Bromeon Follow-up to #142. Two new test features: * `#[itest(skip)]` ignores the current test, and shows the number of skipped tests in a statistic at the end of the run. * This is better than empty tests with `// TODO` or commented-out tests, as it reminds you of the technical debt and gives an impression of its extents. * If at least one test is annotated with `#[itest(focus)]`, then _only_ "focused" tests are run. * Extremely helpful during debugging sessions, or when one is working on a very particular feature. * If Godot is invoked with `-- --disallow-focus`, focus runs will always fail (for CI, to avoid accidental disabling of tests). This is not yet implemented for GDScript. Might be worth it, or might not. Apart from that, this PR massively simplifies the internal APIs to parse `#[attribute(key, key2="value")]` attributes. Co-authored-by: Jan Haller <bromeon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
#[itest]is now self-registering, just like Rust's#[test].ok &= test_xy();shenanigans. When declared, it runs.expect_panic, reducing the stdout spam during integration tests.And unrelated to testing, but needed for this PR:
Variant::call()method