Skip to content

Commit

Permalink
Move virtual_hashes codegen to own file
Browse files Browse the repository at this point in the history
  • Loading branch information
Bromeon committed Dec 26, 2024
1 parent 85723ff commit 52edfe0
Show file tree
Hide file tree
Showing 3 changed files with 63 additions and 53 deletions.
51 changes: 0 additions & 51 deletions godot-codegen/src/generator/method_tables.rs
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,6 @@ pub fn make_utility_function_table(api: &ExtensionApi) -> TokenStream {
make_named_method_table(table)
}

#[cfg(since_api = "4.4")]
pub fn make_virtual_hashes_table(api: &ExtensionApi) -> TokenStream {
make_virtual_hashes_for_all_classes(&api.classes)
}

// ----------------------------------------------------------------------------------------------------------------------------------------------
// Implementation

Expand Down Expand Up @@ -307,52 +302,6 @@ fn make_named_method_table(info: NamedMethodTable) -> TokenStream {
}
}

#[cfg(since_api = "4.4")]
fn make_virtual_hashes_for_all_classes(all_classes: &[Class]) -> TokenStream {
let modules = all_classes
.iter()
.map(|class| make_virtual_hashes_for_class(class));

quote! {
#![allow(non_snake_case, non_upper_case_globals)]

#( #modules )*
}
}

#[cfg(since_api = "4.4")]
fn make_virtual_hashes_for_class(class: &Class) -> TokenStream {
let class_rust_name = &class.name().rust_ty;

let constants: Vec<TokenStream> = class
.methods
.iter()
.filter_map(|method| {
let FnDirection::Virtual { hash } = method.direction() else {
return None;
};

let method_name = method.name_ident();
let constant = quote! {
pub const #method_name: u32 = #hash;
};

Some(constant)
})
.collect();

// Don't generate mod SomeClass {} without contents.
if constants.is_empty() {
return TokenStream::new();
}

quote! {
pub mod #class_rust_name {
#( #constants )*
}
}
}

#[cfg(not(feature = "codegen-lazy-fptrs"))]
fn make_method_table(info: IndexedMethodTable) -> TokenStream {
let IndexedMethodTable {
Expand Down
7 changes: 5 additions & 2 deletions godot-codegen/src/generator/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ pub mod notifications;
pub mod utility_functions;
pub mod virtual_traits;

#[cfg(since_api = "4.4")]
pub mod virtual_hashes;

// ----------------------------------------------------------------------------------------------------------------------------------------------

// Some file generation functions are in specific modules:
Expand Down Expand Up @@ -84,8 +87,8 @@ pub fn generate_sys_classes_file(
// This allows Godot to fall back to an older compatibility function if one is not supported.
#[cfg(since_api = "4.4")]
{
let virtual_hashes_code = method_tables::make_virtual_hashes_table(api);
submit_fn(sys_gen_path.join("virtual_hashes.rs"), virtual_hashes_code);
let code = virtual_hashes::make_virtual_hashes_file(api);
submit_fn(sys_gen_path.join("virtual_hashes.rs"), code);
watch.record("generate_virtual_hashes_file");
}
}
Expand Down
58 changes: 58 additions & 0 deletions godot-codegen/src/generator/virtual_hashes.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
/*
* Copyright (c) godot-rust; Bromeon and contributors.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
*/

use crate::models::domain::{Class, ClassLike, ExtensionApi, FnDirection, Function};
use proc_macro2::TokenStream;
use quote::quote;

pub fn make_virtual_hashes_file(api: &ExtensionApi) -> TokenStream {
make_virtual_hashes_for_all_classes(&api.classes)
}

fn make_virtual_hashes_for_all_classes(all_classes: &[Class]) -> TokenStream {
let modules = all_classes
.iter()
.map(|class| make_virtual_hashes_for_class(class));

quote! {
#![allow(non_snake_case, non_upper_case_globals)]

#( #modules )*
}
}

fn make_virtual_hashes_for_class(class: &Class) -> TokenStream {
let class_rust_name = &class.name().rust_ty;

let constants: Vec<TokenStream> = class
.methods
.iter()
.filter_map(|method| {
let FnDirection::Virtual { hash } = method.direction() else {
return None;
};

let method_name = method.name_ident();
let constant = quote! {
pub const #method_name: u32 = #hash;
};

Some(constant)
})
.collect();

// Don't generate mod SomeClass {} without contents.
if constants.is_empty() {
return TokenStream::new();
}

quote! {
pub mod #class_rust_name {
#( #constants )*
}
}
}

0 comments on commit 52edfe0

Please sign in to comment.