Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

Support Python 3.8. #6

Merged
merged 15 commits into from
Apr 1, 2020
Merged

Support Python 3.8. #6

merged 15 commits into from
Apr 1, 2020

Conversation

sallner
Copy link
Member

@sallner sallner commented Mar 31, 2020

No description provided.

@sallner sallner requested a review from icemac March 31, 2020 10:05
@sallner sallner self-assigned this Mar 31, 2020
@sallner
Copy link
Member Author

sallner commented Mar 31, 2020

This PR fixes #5 and #4.

@sallner sallner requested a review from dhavlik March 31, 2020 12:12
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with only some minimal suggestions.

Successfully tested against icemac.addressbook using Python 2.7.

.gitignore Outdated Show resolved Hide resolved
src/gocept/reference/tests.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@sallner sallner merged commit 24d8095 into master Apr 1, 2020
@sallner sallner deleted the python3 branch April 1, 2020 12:53
@sallner sallner restored the python3 branch April 1, 2020 13:51
@icemac icemac deleted the python3 branch April 3, 2020 05:52
@icemac icemac restored the python3 branch April 3, 2020 05:52
@icemac
Copy link
Member

icemac commented Apr 3, 2020

@sallner Is the branch still needed or can it be deleted?

@sallner sallner deleted the python3 branch August 3, 2020 15:42
@sallner sallner restored the python3 branch August 3, 2020 15:42
@sallner
Copy link
Member Author

sallner commented Aug 3, 2020

Hm, I do maybe at a project.

@sallner sallner deleted the python3 branch January 13, 2021 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants