Include reference to anonymised record in Anony::Result
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using selectors to anonymise records, an array of `Result` objects is returned and these results now contain a reference to the record that was anonymised. This means that it is significantly easier to match the changes from the `fields` on each result with the record that those changes came from in case the changes don't include any unique identifiers like the primary key field.
a6365bc to
b666b23
Compare
stephenbinns
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using selectors to anonymise records, an array of
Anony::Resultobjects is returned and these results now contain a reference to the record that was anonymised.This means that it is significantly easier to match the changes from the
fieldson each result with the record that those changes came from in case the changes don't include any unique identifiers like the primary key field.recordparameter inResultfactory methods has been left as an optional parameter to ensure that we don't break compatibility with downstream users who might have custom strategies that create results