Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(ci): include PR title validation workflow #344

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

ecrupper
Copy link
Contributor

Curious what the thoughts are on something like this. I know we use a script to generate release notes that relies on this pattern.

@ecrupper ecrupper requested a review from a team as a code owner January 16, 2024 04:33
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4d640c) 96.16% compared to head (20c5bf6) 96.16%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          70       70           
  Lines        7481     7481           
=======================================
  Hits         7194     7194           
  Misses        209      209           
  Partials       78       78           

@wass3r
Copy link
Collaborator

wass3r commented Jan 16, 2024

Yes, please. Extra points for not using a third party action 👍 make it required check for all repos. It would be nice if it helpfully told you the right format or a link to docs where it explains?

@ecrupper ecrupper merged commit 00dcbc6 into main Jan 17, 2024
11 checks passed
@ecrupper ecrupper deleted the enhance/ci/pr-title-validator branch January 17, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants