Merge branch 'main' into dependabot/go_modules/golang.org/x/net-0.23.0

.github/workflows/pr-title-validate.yml

@@ -13,5 +13,7 @@ jobs:
 
     steps:
     - name: validate title
+      env:
+        TITLE: ${{ github.event.pull_request.title }}
       run: |
-        echo "${{ github.event.pull_request.title }}" | grep -Eq '^(feat|fix|chore|refactor|enhance|test|docs)(\(.*\)|):\s.+$' && (echo "Pass"; exit 0) || (echo "Incorrect Format. Please see https://go-vela.github.io/docs/community/contributing_guidelines/#development-workflow"; exit 1)
+        echo "$TITLE" | grep -Eq '^(feat|fix|chore|refactor|enhance|test|docs)(\(.*\)|)!?:\s.+$' && (echo "Pass"; exit 0) || (echo "Incorrect Format. Please see https://go-vela.github.io/docs/community/contributing_guidelines/#development-workflow"; exit 1)

.golangci.yml

@@ -75,7 +75,6 @@ linters:
     - bidichk # checks for dangerous unicode character sequences
     - bodyclose # checks whether HTTP response body is closed successfully
     - contextcheck # check the function whether use a non-inherited context
-    - deadcode # finds unused code
     - dupl # code clone detection
     - errcheck # checks for unchecked errors
     - errorlint # find misuses of errors
@@ -101,14 +100,12 @@ linters:
     - nolintlint # reports ill-formed or insufficient nolint directives
     - revive # linter for go
     - staticcheck # applies static analysis checks, go vet on steroids
-    - structcheck # finds unused struct fields
     - stylecheck # replacement for golint
     - tenv # analyzer that detects using os.Setenv instead of t.Setenv since Go1.17
     - typecheck # parses and type-checks go code, like the front-end of a go compiler
     - unconvert # remove unnecessary type conversions
     - unparam # reports unused function parameters
     - unused # checks for unused constants, variables, functions and types
-    - varcheck # finds unused global variables and constants
     - whitespace # detects leading and trailing whitespace
     - wsl # forces code to use empty lines
 

pipeline/container.go

@@ -52,6 +52,7 @@ type (
 		Volumes     VolumeSlice       `json:"volumes,omitempty"     yaml:"volumes,omitempty"`
 		User        string            `json:"user,omitempty"        yaml:"user,omitempty"`
 		ReportAs    string            `json:"report_as,omitempty" yaml:"report_as,omitempty"`
+		IDRequest   string            `json:"id_request,omitempty" yaml:"id_request,omitempty"`
 	}
 )
 
@@ -135,7 +136,8 @@ func (c *Container) Empty() bool {
 		len(c.Ulimits) == 0 &&
 		len(c.Volumes) == 0 &&
 		len(c.User) == 0 &&
-		len(c.ReportAs) == 0 {
+		len(c.ReportAs) == 0 &&
+		len(c.IDRequest) == 0 {
 		return true
 	}
 

pipeline/container_test.go

@@ -932,6 +932,7 @@ func testContainers() *ContainerSlice {
 			Name:        "clone",
 			Number:      2,
 			Pull:        "always",
+			IDRequest:   "yes",
 		},
 		{
 			ID:          "step_github/octocat._1_echo",

yaml/step.go

@@ -35,6 +35,7 @@ type (
 		Privileged  bool                   `yaml:"privileged,omitempty"  json:"privileged,omitempty" jsonschema:"description=Run the container with extra privileges.\nReference: https://go-vela.github.io/docs/reference/yaml/steps/#the-privileged-tag"`
 		User        string                 `yaml:"user,omitempty"        json:"user,omitempty" jsonschema:"description=Set the user for the container.\nReference: https://go-vela.github.io/docs/reference/yaml/steps/#the-user-tag"`
 		ReportAs    string                 `yaml:"report_as,omitempty" json:"report_as,omitempty" jsonschema:"description=Set the name of the step to report as.\nReference: https://go-vela.github.io/docs/reference/yaml/steps/#the-report_as-tag"`
+		IDRequest   string                 `yaml:"id_request,omitempty" json:"id_request,omitempty" jsonschema:"description=Request ID Request Token for the step.\nReference: https://go-vela.github.io/docs/reference/yaml/steps/#the-id_request-tag"`
 	}
 )
 
@@ -62,6 +63,7 @@ func (s *StepSlice) ToPipeline() *pipeline.ContainerSlice {
 			Volumes:     *step.Volumes.ToPipeline(),
 			User:        step.User,
 			ReportAs:    step.ReportAs,
+			IDRequest:   step.IDRequest,
 		})
 	}
 

yaml/step_test.go

@@ -31,6 +31,7 @@ func TestYaml_StepSlice_ToPipeline(t *testing.T) {
 					Privileged:  false,
 					Pull:        "not_present",
 					ReportAs:    "my-step",
+					IDRequest:   "yes",
 					Ruleset: Ruleset{
 						If: Rules{
 							Branch:  []string{"main"},
@@ -88,6 +89,7 @@ func TestYaml_StepSlice_ToPipeline(t *testing.T) {
 					Privileged:  false,
 					Pull:        "not_present",
 					ReportAs:    "my-step",
+					IDRequest:   "yes",
 					Ruleset: pipeline.Ruleset{
 						If: pipeline.Rules{
 							Branch:  []string{"main"},