Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add login using PAT #246

Merged
merged 8 commits into from
Jan 21, 2021
Merged

feat: add login using PAT #246

merged 8 commits into from
Jan 21, 2021

Conversation

sudohikumar
Copy link
Contributor

@sudohikumar sudohikumar commented Jan 18, 2021 •
edited
Loading

@sudohikumar sudohikumar requested a review from a team as a code owner January 18, 2021 06:43
@sudohikumar sudohikumar marked this pull request as draft January 18, 2021 06:44
@sudohikumar sudohikumar mentioned this pull request Jan 18, 2021
Closed
@codecov
Copy link

codecov bot commented Jan 18, 2021 •
edited
Loading

Codecov Report

Merging #246 (c1e777a) into master (db01ce5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   86.83%   86.87%   +0.04%     
==========================================
  Files         117      117              
  Lines        2909     2918       +9     
==========================================
+ Hits         2526     2535       +9     
  Misses        315      315              
  Partials       68       68
Impacted Files Coverage Δ
source/github/authentication.go 86.36% <100.00%> (+3.50%) ⬆️

@sudohikumar sudohikumar marked this pull request as ready for review January 18, 2021 06:54
wass3r
wass3r approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like our linter doesn't handle PR originating from forks well. i think here are couple of things to address, but we can tweak after merge. thanks for the contribution!

@wass3r wass3r merged commit 3f64352 into go-vela:master Jan 21, 2021
@wass3r wass3r mentioned this pull request Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockopp jbrockopp jbrockopp approved these changes

@wass3r wass3r wass3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudohikumar @wass3r @jbrockopp