Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api/docs): undo deprecation #1245

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix(api/docs): undo deprecation #1245

merged 1 commit into from
Jan 22, 2025

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Jan 18, 2025

undo marking log update endpoints as deprecated. they are very much in use.

other endpoints marked as deprecated are creating step/service logs (POST requests). i believe those are truly deprecated and probably up for removal.

undo marking log update endpoints as deprecated.
@wass3r wass3r requested a review from a team as a code owner January 18, 2025 17:36
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.55%. Comparing base (fe9bcaf) to head (2b25fb5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1245   +/-   ##
=======================================
  Coverage   56.55%   56.55%           
=======================================
  Files         629      629           
  Lines       35619    35619           
=======================================
  Hits        20146    20146           
  Misses      14792    14792           
  Partials      681      681           
Files with missing lines Coverage Δ
api/log/update_service.go 0.00% <ø> (ø)
api/log/update_step.go 0.00% <ø> (ø)

Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@wass3rw3rk wass3rw3rk merged commit 8090149 into main Jan 22, 2025
11 of 13 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/api/undo-deprecation branch January 22, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants