Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracing): rename cli key #1187

Merged
merged 2 commits into from
Sep 18, 2024
Merged

chore(tracing): rename cli key #1187

merged 2 commits into from
Sep 18, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Sep 17, 2024

leftover naming from when i pictured the tracing config would only apply to api endpoints
see: #1184

@plyr4 plyr4 requested a review from a team as a code owner September 17, 2024 19:48
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 53.05%. Comparing base (ad3a81f) to head (90d0514).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tracing/config.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1187   +/-   ##
=======================================
  Coverage   53.05%   53.05%           
=======================================
  Files         559      559           
  Lines       19740    19740           
=======================================
  Hits        10473    10473           
  Misses       8699     8699           
  Partials      568      568           
Files with missing lines Coverage Δ
tracing/config.go 0.00% <0.00%> (ø)

@plyr4 plyr4 merged commit 9820efc into main Sep 18, 2024
11 of 13 checks passed
@plyr4 plyr4 deleted the fix/tracing-cli-key branch September 18, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants