Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: platform settings yaml tags #1129

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: platform settings yaml tags #1129

merged 1 commit into from
May 13, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented May 13, 2024

forgot to add yaml tags, necessary for updating from yaml file in the cli

@plyr4 plyr4 requested a review from a team as a code owner May 13, 2024 19:30
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.08%. Comparing base (9357113) to head (42bb2f7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files         410      410           
  Lines       13691    13691           
=======================================
  Hits         9321     9321           
  Misses       3836     3836           
  Partials      534      534           
Files Coverage Δ
api/types/settings/compiler.go 85.00% <ø> (ø)
api/types/settings/platform.go 73.52% <ø> (ø)
api/types/settings/queue.go 77.77% <ø> (ø)

@plyr4 plyr4 merged commit 927dc71 into main May 13, 2024
12 of 14 checks passed
@plyr4 plyr4 deleted the fix/settings-yaml branch May 13, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants