Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct the register worker token swagger path #1128

Merged
merged 1 commit into from
May 13, 2024
Merged

chore: Correct the register worker token swagger path #1128

merged 1 commit into from
May 13, 2024

Conversation

tmapes
Copy link
Contributor

@tmapes tmapes commented May 13, 2024

Noticed in the admin router that this endpoint is wired up under [...]/workers/:worker/register but it's currently documented as [...]/workers/:worker/register-token

@tmapes tmapes requested a review from a team as a code owner May 13, 2024 01:43
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice catch, thank you!

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.08%. Comparing base (27f1163) to head (b2cdc6f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1128   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files         410      410           
  Lines       13691    13691           
=======================================
  Hits         9321     9321           
  Misses       3836     3836           
  Partials      534      534           

@ecrupper ecrupper merged commit 6a9e509 into go-vela:main May 13, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants