Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename settings FromAPI constructor #1126

Merged
merged 2 commits into from
May 13, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented May 10, 2024

No description provided.

@plyr4 plyr4 requested a review from a team as a code owner May 10, 2024 19:40
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.08%. Comparing base (6a9e509) to head (146a874).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1126   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files         410      410           
  Lines       13691    13691           
=======================================
  Hits         9321     9321           
  Misses       3836     3836           
  Partials      534      534           
Files Coverage Δ
database/settings/create.go 60.00% <100.00%> (ø)
database/settings/update.go 63.63% <100.00%> (ø)
database/types/settings.go 64.70% <100.00%> (ø)

@ecrupper ecrupper merged commit 9357113 into main May 13, 2024
14 of 16 checks passed
@ecrupper ecrupper deleted the chore/settings-consistent-api-constructor branch May 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants