-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Vela OIDC provider #1120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1120 +/- ##
==========================================
- Coverage 68.04% 67.27% -0.78%
==========================================
Files 411 422 +11
Lines 13752 14083 +331
==========================================
+ Hits 9358 9474 +116
- Misses 3859 4064 +205
- Partials 535 545 +10
|
plyr4
reviewed
May 16, 2024
plyr4
reviewed
May 21, 2024
wass3rw3rk
reviewed
May 22, 2024
wass3r
requested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spotted a couple of small-ish tings. looks good overall
This was referenced May 30, 2024
plyr4
reviewed
Jun 3, 2024
…nto feat/oidc-provider
…nto feat/oidc-provider
…nto feat/oidc-provider
plyr4
approved these changes
Jun 4, 2024
wass3r
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-vela/community#976
How it works
VELA_ID_TOKEN_REQUEST_URL
(nothing unique about it, just for convenience.. the path is/api/v1/repos/ORG/REPO/builds/BUILD/id_token
).VELA_ID_TOKEN_REQUEST_TOKEN
if the user specifies any value for theid_request
YAML step tag. This request is secured by theMustBuildAccess()
permissions check. The reason this token isn't generated at compile time is because part of the claims involvebuild_id
, which isn't created during compilation due to potential errors.ID_TOKEN_REQUEST_TOKEN
. This request must be made while the build is running, else it will be denied for security reasons.Example