Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: auto cancel builds pending approval when they become obsolete #1066

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

ecrupper
Copy link
Contributor

I am open to making this configurable in the metadata.auto_cancel, but I think presenting the option to approve a build to a repo admin should only involve one build.

This is how Actions does it to some degree. Curious what thoughts are.

@ecrupper ecrupper requested a review from a team as a code owner February 22, 2024 16:42
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9040349) 62.44% compared to head (061cec5) 62.44%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   62.44%   62.44%           
=======================================
  Files         345      345           
  Lines       10251    10254    +3     
=======================================
+ Hits         6401     6403    +2     
- Misses       3376     3377    +1     
  Partials      474      474           
Files Coverage Δ
database/build/list_pending_running_repo.go 88.23% <100.00%> (ø)
api/build/auto_cancel.go 20.95% <33.33%> (+1.34%) ⬆️

@wass3rw3rk
Copy link
Member

wass3rw3rk commented Feb 22, 2024

i think it makes sense. include "pending approval" builds in the auto-cancel process. 👍🏼

@ecrupper ecrupper merged commit 4a5ce4a into main Feb 23, 2024
14 of 16 checks passed
@ecrupper ecrupper deleted the enhance/approval/auto-cancel branch February 23, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants