enhance(api/scm)!: return affected repos in API response and do not assume 404 on GetRepo error #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sume 404 on error
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
=======================================
Coverage 68.36% 68.36%
=======================================
Files 317 317
Lines 13640 13641 +1
=======================================
+ Hits 9325 9326 +1
Misses 3848 3848
Partials 467 467
|
wass3rw3rk
reviewed
Nov 28, 2023
There was a problem hiding this comment.
does that mean the repo sync endpoint could return 204 as well? do we need to lift the response codes the github api can return to our api spec comments in this section: https://github.com/go-vela/server/pull/1015/files#diff-ccd33b844d96fe96ea644179c0ac423c805dc392a9e24117a60d2b269721eb9aL40
timhuynh94
approved these changes
Nov 28, 2023
claire1618
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particularly helpful when syncing repositories is knowing if anything actually changed with the database object. This change has the API response return any affected repo in its response. Otherwise, if nothing changed, it will return a
204 - No Content.Also fixed an issue where any error resulting from the SCM call to
GetRepowas interpreted as a404error. That is not always true.