chore(deps): update all non-major dependencies #523
reviewdog [golangci] report
reported by reviewdog 🐶
Findings (8)
action/pipeline/validate.go|149| 149-197 lines are duplicate of action/pipeline/compile.go:15-63
(dupl)
action/pipeline/exec.go|24| Function 'Exec' is too long (163 > 160) (funlen)
internal/output/yaml_test.go|72 col 39| unused-parameter: parameter 'unmarshal' seems to be unused, consider removing or renaming it as _ (revive)
action/pipeline/validate_test.go|445 col 4| assignments should only be cuddled with other assignments (wsl)
action/pipeline/validate_test.go|446 col 4| only one cuddle assignment allowed before if statement (wsl)
action/pipeline/validate_test.go|450 col 4| if statements should only be cuddled with assignments (wsl)
command/worker/add.go|3 col 1| directive //nolint:dupl // ignore similar code with update
is unused for linter "dupl" (nolintlint)
command/worker/view.go|70 col 1| directive //nolint:dupl // ignore similar code with chown, get, remove and repair
is unused for linter "dupl" (nolintlint)
Filtered Findings (0)
Annotations
Check failure on line 149 in action/pipeline/validate.go
github-actions / golangci
[golangci] action/pipeline/validate.go#L149
149-197 lines are duplicate of `action/pipeline/compile.go:15-63` (dupl)
Raw output
action/pipeline/validate.go:149: 149-197 lines are duplicate of `action/pipeline/compile.go:15-63` (dupl)
func (c *Config) ValidateRemote(client *vela.Client) error {
logrus.Debug("executing validate for remote pipeline configuration")
logrus.Tracef("validating pipeline %s/%s@%s", c.Org, c.Repo, c.Ref)
// set the pipeline options for the call
//
// https://pkg.go.dev/github.com/go-vela/sdk-go/vela?tab=doc#PipelineOptions
opts := &vela.PipelineOptions{
Output: c.Output,
}
// send API call to validate a pipeline
//
// https://pkg.go.dev/github.com/go-vela/sdk-go/vela?tab=doc#PipelineService.Validate
pipeline, _, err := client.Pipeline.Validate(c.Org, c.Repo, c.Ref, opts)
if err != nil {
return err
}
// handle the output based off the provided configuration
switch c.Output {
case output.DriverDump:
// output the pipeline in dump format
//
// https://pkg.go.dev/github.com/go-vela/cli/internal/output?tab=doc#Dump
return output.Dump(pipeline)
case output.DriverJSON:
// output the pipeline in JSON format
//
// https://pkg.go.dev/github.com/go-vela/cli/internal/output?tab=doc#JSON
return output.JSON(pipeline)
case output.DriverSpew:
// output the pipeline in spew format
//
// https://pkg.go.dev/github.com/go-vela/cli/internal/output?tab=doc#Spew
return output.Spew(pipeline)
case output.DriverYAML:
// output the pipeline in YAML format
//
// https://pkg.go.dev/github.com/go-vela/cli/internal/output?tab=doc#YAML
return output.YAML(pipeline)
default:
// output the pipeline in stdout format
//
// https://pkg.go.dev/github.com/go-vela/cli/internal/output?tab=doc#Stdout
return output.Stdout(pipeline)
}
}
Check failure on line 24 in action/pipeline/exec.go
github-actions / golangci
[golangci] action/pipeline/exec.go#L24
Function 'Exec' is too long (163 > 160) (funlen)
Raw output
action/pipeline/exec.go:24: Function 'Exec' is too long (163 > 160) (funlen)
func (c *Config) Exec(client compiler.Engine) error {
Check failure on line 72 in internal/output/yaml_test.go
github-actions / golangci
[golangci] internal/output/yaml_test.go#L72
unused-parameter: parameter 'unmarshal' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
internal/output/yaml_test.go:72:39: unused-parameter: parameter 'unmarshal' seems to be unused, consider removing or renaming it as _ (revive)
func (f *failMarshaler) UnmarshalYAML(unmarshal func(interface{}) error) error {
^
Check failure on line 445 in action/pipeline/validate_test.go
github-actions / golangci
[golangci] action/pipeline/validate_test.go#L445
assignments should only be cuddled with other assignments (wsl)
Raw output
action/pipeline/validate_test.go:445:4: assignments should only be cuddled with other assignments (wsl)
got, err := validateFile(tt.args.path)
^
Check failure on line 446 in action/pipeline/validate_test.go
github-actions / golangci
[golangci] action/pipeline/validate_test.go#L446
only one cuddle assignment allowed before if statement (wsl)
Raw output
action/pipeline/validate_test.go:446:4: only one cuddle assignment allowed before if statement (wsl)
if (err != nil) != tt.wantErr {
^
Check failure on line 450 in action/pipeline/validate_test.go
github-actions / golangci
[golangci] action/pipeline/validate_test.go#L450
if statements should only be cuddled with assignments (wsl)
Raw output
action/pipeline/validate_test.go:450:4: if statements should only be cuddled with assignments (wsl)
if got != tt.want {
^
Check failure on line 3 in command/worker/add.go
github-actions / golangci
[golangci] command/worker/add.go#L3
directive `//nolint:dupl // ignore similar code with update` is unused for linter "dupl" (nolintlint)
Raw output
command/worker/add.go:3:1: directive `//nolint:dupl // ignore similar code with update` is unused for linter "dupl" (nolintlint)
//nolint:dupl // ignore similar code with update
^
Check failure on line 70 in command/worker/view.go
github-actions / golangci
[golangci] command/worker/view.go#L70
directive `//nolint:dupl // ignore similar code with chown, get, remove and repair` is unused for linter "dupl" (nolintlint)
Raw output
command/worker/view.go:70:1: directive `//nolint:dupl // ignore similar code with chown, get, remove and repair` is unused for linter "dupl" (nolintlint)
//nolint:dupl // ignore similar code with chown, get, remove and repair
^