Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): allow users to disable events #502

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

ecrupper
Copy link
Contributor

Adding the --drop-event flag to let the CLI disable webhook events for repos.

Also added a few more aliases and an AlternateDeploy constant ("deploy") because we call the event Deploy in the UI, so it's not very intuitive that it should be supplied as deployment. Made it a constant because the linter was yelling.

@ecrupper ecrupper requested a review from a team as a code owner November 20, 2023 16:24
wass3rw3rk
wass3rw3rk previously approved these changes Nov 20, 2023
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - good call on the deploy thing. do you think we should do similar for pull?

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #502 (f542301) into main (e4f3af7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head f542301 differs from pull request most recent head 9310675. Consider uploading reports for the commit 9310675 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   85.99%   86.03%   +0.03%     
==========================================
  Files         145      145              
  Lines        6347     6364      +17     
==========================================
+ Hits         5458     5475      +17     
  Misses        732      732              
  Partials      157      157              
Files Coverage Δ
action/repo/add.go 96.05% <100.00%> (ø)
action/repo/update.go 100.00% <100.00%> (ø)
command/repo/add.go 91.89% <ø> (ø)
command/repo/update.go 92.10% <100.00%> (+0.21%) ⬆️

plyr4
plyr4 previously approved these changes Nov 20, 2023
@ecrupper ecrupper dismissed stale reviews from plyr4 and wass3rw3rk via 9310675 November 20, 2023 16:40
@ecrupper ecrupper merged commit b070b17 into main Nov 20, 2023
@ecrupper ecrupper deleted the fix/repo/handle-drop-events branch November 20, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants