Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(registration): derive hostname from address #440

Merged
merged 2 commits into from
Apr 20, 2023
Merged

enhance(registration): derive hostname from address #440

merged 2 commits into from
Apr 20, 2023

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Apr 20, 2023 •
edited
Loading

  • add some clarity to add worker command
  • add convenience of making hostname optional to supply. will use hostname of address by default (that's what the worker does also)
  • update validation

@wass3r wass3r requested a review from a team as a code owner April 20, 2023 03:13
@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Merging #440 (6cc18a7) into main (20ecef6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   85.96%   86.00%   +0.03%     
==========================================
  Files         133      133              
  Lines        5800     5815      +15     
==========================================
+ Hits         4986     5001      +15     
  Misses        666      666              
  Partials      148      148
Impacted Files Coverage Δ
command/worker/update.go 88.46% <ø> (ø)
action/worker/validate.go 100.00% <100.00%> (ø)
command/worker/add.go 90.00% <100.00%> (+2.00%) ⬆️

ecrupper
ecrupper previously approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - lgtm

@wass3r
Copy link
Collaborator Author

wass3r commented Apr 20, 2023

/merge

@ecrupper ecrupper merged commit 082ff30 into main Apr 20, 2023
@ecrupper ecrupper deleted the enhance/registration branch April 20, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecrupper ecrupper ecrupper approved these changes

@plyr4 plyr4 plyr4 approved these changes

@timhuynh94 timhuynh94 timhuynh94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wass3r @timhuynh94 @plyr4 @ecrupper