Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from sprig to slim-sprig #219

Merged
merged 1 commit into from
Jun 23, 2019
Merged

Conversation

andreynering
Copy link
Member

slim-sprig is a fork of sprig that don't import external (non-stdlib) packages. I also deleted some crypto functions that, while present on stdlib, is very unlikely to be used by any Task user.

6 external dependencies are removed by this change. 🙂

This will only be shipped for v3.

Stats - Task binary file size (macOS)

Without -ldflags="-w -s":

  • Before 8.4M
  • After: 6.6M
  • Reduced by: ~22%

With -ldflags="-w -s":

  • Before: 6.7M
  • After: 5.2M
  • Reduced by ~23%

@andreynering andreynering added this to the v3 milestone Jun 23, 2019
@andreynering andreynering merged commit f6f31e0 into v3 Jun 23, 2019
@andreynering andreynering deleted the migrate-from-sprig-to-slim-sprig branch June 23, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant