Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop repeated queries #617

Closed

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Jun 11, 2017

Description

This pull request fixes the following issue.

It is separated from #302.
Handling errors of WRITE operations still needs more consideration, while I think that handling errors of READ operations can be fixed.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienschmidt
Copy link
Member

This PR needs an update since #302 was merged

@julienschmidt julienschmidt added this to the v1.4 milestone Sep 13, 2017
@julienschmidt
Copy link
Member

@shogo82148 would you like to propose changes to the now implemented behavior?
If yes, please update this PR or otherwise please close it.

@shogo82148
Copy link
Contributor Author

I think that #302 solves the problem, so this pull request doesn't need any more.
Thanks.

@shogo82148 shogo82148 closed this Oct 17, 2017
@shogo82148 shogo82148 deleted the stop-repeated-queries branch August 18, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants