fixing golangci-lint@1.60.3 errors of current build #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvilaverde
commented
Sep 1, 2024
| // When this project supports golang 1.20 as a minimum, then this mrand.New(...) | ||
| // line can be eliminated and the random number can be generated by simply | ||
| // calling mrand.Intn() | ||
| random := mrand.New(mrand.NewSource(time.Now().UTC().UnixNano())) |
There was a problem hiding this comment.
Although this line is no longer needed with golang 1.20+ and simply the call to mrand.Intn() can be used, I've created a new random from a Source because this projects go.mod declares golang 1.18. But left a note in the code for future reference.
dvilaverde
commented
Sep 1, 2024
| @@ -203,7 +203,7 @@ func (c *conn) CheckNamedValue(nv *sqldriver.NamedValue) error { | |||
| } else { | |||
| // we've found an error, if the error is driver.ErrSkip then | |||
| // keep looking otherwise return the unknown error | |||
| if !goErrors.Is(sqldriver.ErrSkip, err) { | |||
| if !goErrors.Is(err, sqldriver.ErrSkip) { | |||
There was a problem hiding this comment.
the arguments were in the wrong order here.
lance6716
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the current build had a failure during golangci-lint check. Simply addressing those.