speed up gtid process for mysql #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GMHDBJD
commented
Nov 17, 2022
- add InsertInterval for mysql gtidset
lance6716
reviewed
Nov 21, 2022
lance6716
reviewed
Nov 23, 2022
mysql/mysql_gtid.go
Outdated
| } | ||
| i++ | ||
| if count > 0 { | ||
| for i != total { |
There was a problem hiding this comment.
seems we can use a copy to move multiple elements with count offset, and truncate the last count elements
if count > 0 {
i++
copy((*s)[i:], (*s)[i+count:])
*s = (*s)[:total-count]
}
mysql/mysql_gtid.go
Outdated
| @@ -439,6 +484,17 @@ func (s *MysqlGTIDSet) Update(GTIDStr string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (s *MysqlGTIDSet) AddGTID(uuid uuid.UUID, gno int64) error { | |||
lance6716
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.