return EOF response on COM_SET_OPTION commands #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
reviewed
Jun 18, 2021
| @@ -125,6 +125,12 @@ func (c *Conn) dispatch(data []byte) interface{} { | |||
| } else { | |||
| return r | |||
| } | |||
| case COM_SET_OPTION: | |||
| if err := c.h.HandleOtherCommand(cmd, data); err != nil { | |||
There was a problem hiding this comment.
Currently this is always EmptyHandler, so always returns an error 🤔 . Is this your expectation?
There was a problem hiding this comment.
Well in my server implementation I implemented a Handler that does handle these commands. And EmptyHandler would've returned an error for this anyway.
Or perhaps I don't understand what you mean?
lance6716
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm implementing a server that needs to respect the
CLIENT_MULTI_STATEMENTScapability and theMYSQL_OPTION_MULTI_STATEMENTS_ONand_OFFoptions that can be set throughCOM_SET_OPTION. According to the docs it is supposed to return EOF on success so I added a backwards compatible way of handling these commands properly.