Skip to content

Commit

Permalink
replication - just return an error not logging it
Browse files Browse the repository at this point in the history
  • Loading branch information
atercattus committed Jan 30, 2023
1 parent c4a17aa commit a139a3f
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions replication/row_event.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (

"github.com/pingcap/errors"
"github.com/shopspring/decimal"
"github.com/siddontang/go-log/log"
"github.com/siddontang/go/hack"

. "github.com/go-mysql-org/go-mysql/mysql"
Expand Down Expand Up @@ -906,9 +905,7 @@ func (e *RowsEvent) DecodeData(pos int, data []byte) (err2 error) {
// ... repeat rows until event-end
defer func() {
if r := recover(); r != nil {
errStr := fmt.Sprintf("parse rows event panic %v, data %q, parsed rows %#v, table map %#v", r, data, e, e.Table)
log.Errorf("%s\n%s", errStr, Pstack())
err2 = errors.Trace(errors.New(errStr))
err2 = errors.Errorf("parse rows event panic %v, data %q, parsed rows %#v, table map %#v", r, data, e, e.Table)
}
}()

Expand Down

0 comments on commit a139a3f

Please sign in to comment.