Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Update debug metadata generation to LLVM 3.4 #141

Merged
merged 2 commits into from
Apr 19, 2014
Merged

Update debug metadata generation to LLVM 3.4 #141

merged 2 commits into from
Apr 19, 2014

Conversation

axw
Copy link
Member

@axw axw commented Apr 17, 2014

  • Update descriptors to match LLVM 3.4, and add the "Dwarf Version" and "Debug Info Version" module flags metadata.
  • Map go/types.Signature to subroutine composite type descriptor, rather than to a struct.

@axw
Copy link
Member Author

axw commented Apr 17, 2014

When I started using LLVM 3.4, I found that the metadata llgo was generating was no longer translating to DWARF. This change fixes that.

@quarnster
Copy link
Contributor

#79 is related

@axw
Copy link
Member Author

axw commented Apr 19, 2014

Just wanted to note: this is a bandaid, and I still intend to look at providing a wrapper for DIBuilder. Doesn't look difficult, just a little tedious.

@pcc
Copy link
Contributor

pcc commented Apr 19, 2014

LGTM

This looks fine for now until we switch to DIBuilder.

pcc added a commit that referenced this pull request Apr 19, 2014
@pcc
Merge pull request #141 from axw/libgo-debug
1a0519c 
Update debug metadata generation to LLVM 3.4
@pcc pcc merged commit 1a0519c into go-llvm:libgo Apr 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axw @quarnster @pcc