Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default value handling and type conversion #437

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

wesen
Copy link
Collaborator

@wesen wesen commented Feb 18, 2025

Enhances the parameter system's handling of default values:

  • Change CheckParameterDefaultValueValidity to return converted value instead of just
    validating
  • Add proper type conversion for rename-regexp fields
  • Update GitHub Actions to latest versions

Key changes:

  • Default values are now properly converted to their target type during validation

Testing:

  • Added enhanced value comparison helper for test assertions

@wesen wesen merged commit 4c0df1f into go-go-golems:main Feb 18, 2025
2 checks passed
@wesen wesen deleted the task/convert-date-defaults-properly branch February 18, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant