Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Database Preparation #9826

Merged
merged 21 commits into from
Feb 18, 2020
Merged

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Jan 17, 2020

Preparing MySQL and PostgreSQL for Gitea.

This will close #9499.

@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #9826 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9826      +/-   ##
==========================================
+ Coverage   43.48%   43.49%   +0.01%     
==========================================
  Files         567      567              
  Lines       79104    79104              
==========================================
+ Hits        34400    34408       +8     
+ Misses      40456    40448       -8     
  Partials     4248     4248
Impacted Files Coverage Δ
services/pull/check.go 54.54% <0%> (-2.1%) ⬇️
modules/queue/workerpool.go 45.55% <0%> (-1.07%) ⬇️
routers/repo/view.go 40% <0%> (+0.86%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
services/pull/patch.go 69.81% <0%> (+1.88%) ⬆️
models/unit.go 39.5% <0%> (+2.46%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f87865...732317b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 17, 2020
@sapk sapk added the type/docs This PR mainly updates/creates documentation label Jan 17, 2020
@6543
Copy link
Member

6543 commented Jan 17, 2020

Just thinking if its worth it to ad a how to mysql and a how to postgress to gitea?

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the utf8 issue is properly cleared.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 18, 2020
@lunny
Copy link
Member

lunny commented Jan 19, 2020

And I think you could also mention, once you chose to use utf8mb4, it may report the index size is too large and you may want to

SET GLOBAL innodb_file_format=Barracuda;
SET GLOBAL innodb_file_per_table=ON;
SET GLOBAL innodb_large_prefix=1;

@bagasme
Copy link
Contributor Author

bagasme commented Jan 19, 2020

@lunny Should your suggestion (SET GLOBALs) be applied before or after database creation?

@lunny
Copy link
Member

lunny commented Jan 19, 2020

@bagasme before database creation.

@bagasme
Copy link
Contributor Author

bagasme commented Jan 19, 2020

@lunny I think those SET GLOBALs aren't needed for MariaDB 10.2.2 and later because those already been set as default.

@silverwind
Copy link
Member

For MySQL, those three settings are also the default since 5.7 I think. Assuming new installations use at least that version, I think it's better to omit them. utf8mb4 is default since 8.0.

It is assumed that such global variables value are already as default on MySQL 5.7 and later, so those are redundant.
@bagasme bagasme requested a review from lunny January 22, 2020 05:46
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2020
@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #9826 into master will decrease coverage by <.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9826      +/-   ##
=========================================
- Coverage    43.4%   43.4%   -0.01%     
=========================================
  Files         576     576              
  Lines       79632   79623       -9     
=========================================
- Hits        34568   34557      -11     
- Misses      40785   40787       +2     
  Partials     4279    4279
Impacted Files Coverage Δ
routers/org/setting.go 0% <ø> (ø) ⬆️
modules/templates/helper.go 40.36% <ø> (ø) ⬆️
routers/api/v1/admin/user.go 30.19% <0%> (-0.4%) ⬇️
modules/base/tool.go 62.94% <100%> (-1.83%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a8b41...fb0f3f3. Read the comment docs.

@techknowlogick techknowlogick merged commit 530f896 into go-gitea:master Feb 18, 2020
@bagasme bagasme deleted the new/database-prep branch March 28, 2020 10:42
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] [Docs] Correct Database Collation?
10 participants