-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Database Preparation #9826
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9826 +/- ##
==========================================
+ Coverage 43.48% 43.49% +0.01%
==========================================
Files 567 567
Lines 79104 79104
==========================================
+ Hits 34400 34408 +8
+ Misses 40456 40448 -8
Partials 4248 4248
Continue to review full report at Codecov.
|
Just thinking if its worth it to ad a how to mysql and a how to postgress to gitea? |
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the utf8 issue is properly cleared.
And I think you could also mention, once you chose to use utf8mb4, it may report the index size is too large and you may want to
|
@lunny Should your suggestion ( |
@bagasme before database creation. |
@lunny I think those |
For MySQL, those three settings are also the default since 5.7 I think. Assuming new installations use at least that version, I think it's better to omit them. |
It is assumed that such global variables value are already as default on MySQL 5.7 and later, so those are redundant.
Codecov Report
@@ Coverage Diff @@
## master #9826 +/- ##
=========================================
- Coverage 43.4% 43.4% -0.01%
=========================================
Files 576 576
Lines 79632 79623 -9
=========================================
- Hits 34568 34557 -11
- Misses 40785 40787 +2
Partials 4279 4279
Continue to review full report at Codecov.
|
Preparing MySQL and PostgreSQL for Gitea.
This will close #9499.