Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract actions on new pull request from models to pulls service and move code.gitea.io/gitea/modules/pull to code.gitea.io/gitea/services/pull #8218

Merged
merged 7 commits into from
Sep 27, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 18, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 18, 2019
services/pulls/pulls.go Outdated Show resolved Hide resolved
services/pulls/pulls.go Outdated Show resolved Hide resolved
services/pulls/pulls.go Outdated Show resolved Hide resolved
services/pulls/pulls.go Outdated Show resolved Hide resolved
services/pulls/pulls.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 18, 2019
@lunny
Copy link
Member Author

lunny commented Sep 25, 2019

@lafriks done.

@@ -20,6 +20,7 @@ import (
api "code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/modules/timeutil"
milestone_service "code.gitea.io/gitea/services/milestone"
pull_service "code.gitea.io/gitea/services/pulls"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import declared with same name as import above:

pull_service "code.gitea.io/gitea/modules/pull"

services/pulls/pulls.go Outdated Show resolved Hide resolved
@lunny lunny changed the title Extract actions on new pull request from models to pulls service Extract actions on new pull request from models to pulls service and move code.gitea.io/gitea/modules/pull to code.gitea.io/gitea/services/pull Sep 25, 2019
@lunny
Copy link
Member Author

lunny commented Sep 25, 2019

@lafriks done and moved code.gitea.io/gitea/modules/pull to code.gitea.io/gitea/services/pull

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #8218 into master will decrease coverage by <.01%.
The diff coverage is 61.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8218      +/-   ##
==========================================
- Coverage   41.55%   41.54%   -0.01%     
==========================================
  Files         492      493       +1     
  Lines       65355    65360       +5     
==========================================
+ Hits        27155    27157       +2     
- Misses      34704    34706       +2     
- Partials     3496     3497       +1
Impacted Files Coverage Δ
models/pull.go 54.3% <ø> (-0.62%) ⬇️
routers/repo/pull_review.go 0% <ø> (ø) ⬆️
services/pull/review.go 0% <ø> (ø)
services/pull/merge.go 36.9% <ø> (ø)
services/pull/lfs.go 71.16% <ø> (ø)
services/pull/commit_status.go 10% <ø> (ø)
routers/api/v1/repo/pull.go 37.04% <0%> (ø) ⬆️
routers/repo/pull.go 30.2% <0%> (ø) ⬆️
services/pull/pull.go 70% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b9278...06eeea3. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 26, 2019
@lunny
Copy link
Member Author

lunny commented Sep 27, 2019

make L-G-T-M work

@lunny lunny merged commit eb11ca6 into go-gitea:master Sep 27, 2019
@lunny lunny deleted the lunny/move_pr branch November 18, 2020 04:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants