Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move code.gitea.io/git to code.gitea.io/gitea/modules/git #6364

Merged
merged 21 commits into from
Mar 27, 2019
Merged

move code.gitea.io/git to code.gitea.io/gitea/modules/git #6364

merged 21 commits into from
Mar 27, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 19, 2019

will replace #5991

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Mar 19, 2019
@lunny lunny added this to the 1.9.0 milestone Mar 19, 2019
@lunny lunny mentioned this pull request Mar 19, 2019
Closed
@lunny
Copy link
Member Author

lunny commented Mar 19, 2019

will partially fix #5954

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2019
@lunny lunny force-pushed the lunny/add_git_as_module2 branch from e5de702 to 7e94ca1 Compare March 20, 2019 01:49
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 20, 2019
@filipnavara filipnavara mentioned this pull request Mar 21, 2019
Closed
@lunny lunny force-pushed the lunny/add_git_as_module2 branch 2 times, most recently from 002683c to 972ff0f Compare March 26, 2019 00:41
@lunny lunny mentioned this pull request Mar 26, 2019
Closed
@lunny lunny force-pushed the lunny/add_git_as_module2 branch from af5905b to c42efe0 Compare March 27, 2019 05:46
@codecov-io
Copy link

codecov-io commented Mar 27, 2019 •
edited
Loading

Codecov Report

Merging #6364 into master will increase coverage by 0.52%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6364      +/-   ##
==========================================
+ Coverage   38.86%   39.39%   +0.52%     
==========================================
  Files         365      393      +28     
  Lines       51414    53264    +1850     
==========================================
+ Hits        19983    20984    +1001     
- Misses      28561    29294     +733     
- Partials     2870     2986     +116
Impacted Files Coverage Δ
models/repo_branch.go 58.27% <ø> (ø) ⬆️
modules/git/tree.go 64.81% <ø> (ø)
models/repo_tag.go 62.5% <ø> (ø) ⬆️
routers/init.go 68.49% <ø> (ø) ⬆️
modules/uploader/upload.go 0% <ø> (ø) ⬆️
routers/repo/setting.go 10.05% <ø> (ø) ⬆️
modules/git/repo_tag.go 56.56% <ø> (ø)
modules/git/tree_entry.go 73.73% <ø> (ø)
models/graph.go 81.03% <ø> (ø) ⬆️
routers/repo/view.go 41.08% <ø> (-1%) ⬇️
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d056bf3...707b69d. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 27, 2019
zeripath
zeripath reviewed Mar 27, 2019
View reviewed changes
modules/git/hook.go
}
h.IsActive = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not move this above the ifExist?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just update the current codes on github.com/go-gitea/git.

@lunny lunny merged commit d578b71 into go-gitea:master Mar 27, 2019
@lunny lunny deleted the lunny/add_git_as_module2 branch March 27, 2019 09:33
@Mikescher Mikescher mentioned this pull request Mar 27, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath left review comments

@adelowo adelowo adelowo approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @zeripath @sapk @adelowo @GiteaBot