Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent empty review comment #4632

Merged
merged 3 commits into from
Aug 7, 2018
Merged

prevent empty review comment #4632

merged 3 commits into from
Aug 7, 2018

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Aug 7, 2018

Fixes #4630

screen shot 2018-08-07 at 13 01 32

adelowo added 3 commits August 7, 2018 13:03
@adelowo
prevent empty review comment
3757e6a 
This would only require a comment for rejection and comment
@adelowo
add tests
ce6718e
@adelowo
add comment
12124ef
@codecov-io
Copy link

Codecov Report

Merging #4632 into master will decrease coverage by 0.16%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4632      +/-   ##
==========================================
- Coverage   20.81%   20.64%   -0.17%     
==========================================
  Files         158      166       +8     
  Lines       31917    32247     +330     
==========================================
+ Hits         6642     6657      +15     
- Misses      24297    24612     +315     
  Partials      978      978
Impacted Files Coverage Δ
routers/repo/pull_review.go 0% <0%> (ø) ⬆️
modules/auth/repo_form.go 13.26% <100%> (ø)
modules/auth/user_form.go 0% <0%> (ø)
modules/auth/user_form_auth_openid.go 0% <0%> (ø)
modules/auth/repo_branch_form.go 0% <0%> (ø)
modules/auth/org.go 0% <0%> (ø)
modules/auth/auth_form.go 0% <0%> (ø)
modules/auth/admin.go 0% <0%> (ø)
modules/auth/auth.go 1.11% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b10e6...12124ef. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 7, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 7, 2018
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 7, 2018
@techknowlogick techknowlogick added this to the 1.6.0 milestone Aug 7, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 7, 2018
@lafriks lafriks merged commit 0df7cab into go-gitea:master Aug 7, 2018
@adelowo adelowo deleted the reject_empty_review_comment branch August 8, 2018 10:11
@adelowo adelowo mentioned this pull request Aug 19, 2018
Merged
adelowo added a commit to adelowo/gitea that referenced this pull request Aug 19, 2018
@adelowo
Redirect to files diff as a little update to go-gitea#4632
654daad
jonasfranz pushed a commit that referenced this pull request Aug 20, 2018
@adelowo @jonasfranz
User shouldn't be able to approve or reject his/her own PR (#4729)
6c1a31f 
* Make sure author cannot reject/approve their own PR

* Disable buttons in templates too

* Remove unneccessary if check since the switch below catches it

* Fix IsOwner check

* Update template and remove new template variable

* Add alert template and redirect to diff page on review failure

* Redirect to files diff as a little update to #4632
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

User can post an empty comment review
5 participants
@adelowo @codecov-io @techknowlogick @lafriks @bkcsoft