Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in HTML attribute #33599

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix typo in HTML attribute #33599

merged 1 commit into from
Feb 14, 2025

Conversation

silverwind
Copy link
Member

No real impact but was still a bug:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 14, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2025
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 14, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 14, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 14, 2025
@techknowlogick techknowlogick merged commit 1ba7cbb into go-gitea:main Feb 14, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 14, 2025
@silverwind silverwind deleted the typo1 branch February 14, 2025 16:22
@wxiaoguang
Copy link
Contributor

No real impact but was still a bug:

If "no real impact", why not just remove these useless "tw-xxx" tricks?

@silverwind
Copy link
Member Author

I don't know their purpose, but yes, they can probably be removed. Should just ensure that the changes are in sync with template-rendered paginations.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 15, 2025 •
edited
Loading

Actually these mr/ml tricks were added by you: Replace more icons with SVG, repo search tweaks (#13860)

They survive to today during various refatorings.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @wxiaoguang @techknowlogick @delvh @GiteaBot