Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.23.0-rc0 changelog #32863

Merged
merged 12 commits into from
Dec 17, 2024
Merged

Conversation

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 16, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2024
@lunny lunny changed the base branch from main to release/v1.23 December 16, 2024 22:51
@lunny lunny marked this pull request as ready for review December 16, 2024 22:51
wxiaoguang
wxiaoguang previously approved these changes Dec 17, 2024
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more than 800 commits, which are omitted? Maybe the omitted ones could be mentioned together.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 17, 2024
@lunny
Copy link
Member Author

lunny commented Dec 17, 2024

There are more than 800 commits, which are omitted? Maybe the omitted ones could be mentioned together.

Some of pull requests haven't been added to the changelog

  • Which have been backported to v1.22
  • Which have skip-changelog
  • No type label marked may be missed, I need to check one by one, but I believe those are not too much.

Do you think should we list these pull requests in the changelog?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 17, 2024

Do you think should we list these pull requests in the changelog?

Nope, I just mean "maybe mention them together by a summary" if anything is useful to end users, it's up to you.

If they are not useful, then no need to process them.

@lunny
Copy link
Member Author

lunny commented Dec 17, 2024

I will mentioned them in the pull request so that commit message can contain them.

@wxiaoguang
Copy link
Contributor

commit message can contain them.

No idea what is that, maybe it would be noisy?

@lunny
Copy link
Member Author

lunny commented Dec 17, 2024

Not the contents themself but a link point to the pull request list.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Dec 17, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Dec 17, 2024
@wxiaoguang
Copy link
Contributor

Backport 1.23 #32868

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2024
@lunny lunny merged commit c8ffe77 into go-gitea:release/v1.23 Dec 17, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Dec 17, 2024
@lunny lunny deleted the lunny/changelog_1.23.0-rc0 branch December 17, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants