Fix various trivial problems #32861
Merged
Fix various trivial problems #32861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Dec 16, 2024
|
No need to wait for this if you'd like to release 1.23 |
f820e4b to
b6504ea
Compare
delvh
approved these changes
Dec 16, 2024
| @@ -12,6 +12,9 @@ import ( | |||
| "code.gitea.io/gitea/modules/setting" | |||
| ) | |||
|
|
|||
| // CanUserForkBetweenOwners returns true if user can fork between owners. | |||
| // By default, a user can fork a repository from another owner, but not from themselves. | |||
| // Many users really like to fork their own repositories, so add an experimental setting to allow this. | |||
There was a problem hiding this comment.
Suggested change
| // Many users really like to fork their own repositories, so add an experimental setting to allow this. | |
| // TODO: Many users really like to fork their own repositories, so add an experimental setting to allow this. |
There was a problem hiding this comment.
But it is describing the fact, it is not a TODO
There was a problem hiding this comment.
Wait, we have this setting already?
Because as far as I'm aware, we have no such setting yet.
And without the TODO, it sounds like the setting exists already…
There was a problem hiding this comment.
Allow to fork repository into the same owner #32819
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
|
Should this be backported to release/v1.23? |
|
Yes if you have tagged. |
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Dec 17, 2024
1. add/improve comments to help future readers could understand the problem more easily. 2. add an error log to LDAP with username fallback 3. use `or` instead of `Iif` for "repo/branch_dropdown" (`Iif` was a mistake, but it doesn't really affect the UI) 4. add `tw-font-mono` style to container digest to match dockerhub 5. fix a bug in RepoBranchTagSelector: the form is not updated when there is no click to an item --------- Co-authored-by: delvh <dev.lh@web.de>
|
Backport 1.23 #32868 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orinstead ofIiffor "repo/branch_dropdown" (Iifwas a mistake, but it doesn't really affect the UI)tw-font-monostyle to container digest to match dockerhub