Fix unclickable checkboxes #30195
Merged
Fix unclickable checkboxes #30195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
approved these changes
Mar 30, 2024
lafriks
approved these changes
Mar 31, 2024
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 31, 2024
Fix go-gitea#30185, regression from go-gitea#30162. The checkboxes were unclickable because the label was positioned over the checkbox with `padding`. Now it uses `margin` so the checkbox itself will be clickable in all cases. Secondly, I changed the for/id linking to also add missing `for` attributes when `id` is present. The other way around (only `for` present) is currently not handled and I think there are likey no occurences in the code and introducing new non-generated `id`s might cause problems elsewhere if we do, so I skipped on that.
silverwind
added a commit
that referenced
this pull request
Mar 31, 2024
Backport #30195 by @silverwind Fix #30185, regression from #30162. The checkboxes were unclickable because the label was positioned over the checkbox with `padding`. Now it uses `margin` so the checkbox itself will be clickable in all cases. Secondly, I changed the for/id linking to also add missing `for` attributes when `id` is present. The other way around (only `for` present) is currently not handled and I think there are likey no occurences in the code and introducing new non-generated `id`s might cause problems elsewhere if we do, so I skipped on that. Co-authored-by: silverwind <me@silverwind.io>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 31, 2024
* giteaofficial/main: Do not allow different storage configurations to point to the same directory (go-gitea#30169) Fix GPG subkey verify (go-gitea#30193) [skip ci] Updated translations via Crowdin Fix unclickable checkboxes (go-gitea#30195) Remove jQuery class from the issue author dropdown (go-gitea#30188) Remove jQuery class from the comment edit history (go-gitea#30186) Remove jQuery class from the repository branch settings (go-gitea#30184) [skip ci] Updated translations via Crowdin Use Crowdin action for translation sync (go-gitea#30054) Remove jQuery class from the project page (go-gitea#30183) Remove jQuery class from the comment context menu (go-gitea#30179)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30185, regression from #30162.
The checkboxes were unclickable because the label was positioned over the checkbox with
padding. Now it usesmarginso the checkbox itself will be clickable in all cases.Secondly, I changed the for/id linking to also add missing
forattributes whenidis present. The other way around (onlyforpresent) is currently not handled and I think there are likey no occurences in the code and introducing new non-generatedids might cause problems elsewhere if we do, so I skipped on that.