Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use hosted runners for nightly actions (#27485) #27488

Merged
merged 3 commits into from
Oct 9, 2023
Merged

use hosted runners for nightly actions (#27485) #27488

merged 3 commits into from
Oct 9, 2023

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Oct 6, 2023

Backport #27485 by @techknowlogick

I'm temporarily unable to properly evaluate actuated runners, and so I'm switching back to hosted runners until I am able to focus on that again.

@techknowlogick @silverwind @GiteaBot
use hosted runners for nightly actions (go-gitea#27485)
3079a4a 
I'm temporarily unable to properly evaluate actuated runners, and so I'm
switching back to hosted runners until I am able to focus on that again.

---------

Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 6, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Oct 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 6, 2023
@GiteaBot GiteaBot requested review from delvh and silverwind October 6, 2023 19:13
techknowlogick
techknowlogick requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking temporarily

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 6, 2023
@techknowlogick
Copy link
Member

@silverwind I'm not sure I've done the reusable workflow correctly. I ended up moving to its own job in main, but that doesn't make sense since I think it should clean in each job rather than by itself.

@silverwind
Copy link
Member

silverwind commented Oct 7, 2023 •
edited
Loading

I wonder if there are more lightweight images available, would certainly be better than cleaning up all this crap which takes minutes.

silverwind
silverwind previously approved these changes Oct 7, 2023
View reviewed changes
@silverwind silverwind dismissed their stale review October 7, 2023 11:00

testing, please ignore

@silverwind
Copy link
Member

silverwind commented Oct 7, 2023 •
edited
Loading

There is a lint failure on main branch, we need to alter actionlint config:

.github/workflows/release-nightly.yml:15:14: label "nscloud" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-latest-xl", "macos-13-xl", "macos-13", "macos-13.0", "macos-12-xl", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows", "actuated-4cpu-8gb", "actuated-4cpu-16gb". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
   |
15 |     runs-on: nscloud

Edit: fixed by #27513

@silverwind silverwind mentioned this pull request Oct 7, 2023
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Oct 9, 2023
@techknowlogick techknowlogick merged commit 9a64a24 into go-gitea:release/v1.21 Oct 9, 2023
@techknowlogick techknowlogick deleted the backport-27485-v1.21 branch October 9, 2023 18:10
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees

@techknowlogick techknowlogick

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @techknowlogick @silverwind