Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use minimal required version on CI and remove unnecessary services #27429

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Use minimal required version on CI and remove unnecessary services #27429

merged 5 commits into from
Oct 4, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 4, 2023

No description provided.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Oct 4, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 4, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 4, 2023
@github-actions github-actions bot removed the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Oct 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 4, 2023
@silverwind
Copy link
Member

mssql too? 2012 instead of 2022.

@lunny
Copy link
Member Author

lunny commented Oct 4, 2023

mssql too? 2012 instead of 2022.

Looks like 2017 is the minimal container we can find so that move it to 2017.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Oct 4, 2023
@github-actions github-actions bot removed the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Oct 4, 2023
@lunny lunny changed the title Use minial required versio on CI and remove unnecessary services Use minimal required version on CI and remove unnecessary services Oct 4, 2023
silverwind
silverwind approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should later extend to test oldest and newest but it will require Makefile changes etc.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 4, 2023
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2023
@lunny lunny enabled auto-merge (squash) October 4, 2023 11:12
@lunny lunny merged commit 74763f5 into go-gitea:main Oct 4, 2023
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 4, 2023
@lunny lunny deleted the lunny/improve_ci branch October 4, 2023 13:28
silverwind added a commit to silverwind/gitea that referenced this pull request Oct 4, 2023
@silverwind
Merge main, rename to gitea-auto
454e475 
* origin/main:
  When comparing with an non-exist repository, return 404 but 500 (go-gitea#27437)
  Fix pr template (go-gitea#27436)
  Use minimal required version on CI and remove unnecessary services (go-gitea#27429)
  Fix  missing `ctx`  in new_form.tmpl  (go-gitea#27434)
  Use flex-container for repo and org settings (go-gitea#27418)
  Fix yet another `ctx` template bug (go-gitea#27417)
  Add Index to `action.user_id` (go-gitea#27403)
  [skip ci] Updated translations via Crowdin
@lunny lunny mentioned this pull request Nov 1, 2023
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/testing
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @silverwind @delvh @GiteaBot