Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/process: add ExecDirEnv (next to ExecDir) #273

Merged
merged 1 commit into from
Nov 27, 2016
Merged

modules/process: add ExecDirEnv (next to ExecDir) #273

merged 1 commit into from
Nov 27, 2016

Conversation

typeless
Copy link
Contributor

Add a sibling to ExecDir which is capable of specifying environment variables,
so that we can invoke git with GIT_INDEX_FILE, GIT_DIR, etc..

For #258

@lunny lunny added the type/enhancement An improvement of existing functionality label Nov 27, 2016
@lunny lunny added this to the 1.0.0 milestone Nov 27, 2016
@lunny
Copy link
Member

lunny commented Nov 27, 2016

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 27, 2016
@thibaultmeyer
Copy link
Contributor

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 27, 2016
@typeless
modules/process: add ExecDirEnv (next to ExecDir)
9aaf2a6 
Add a sibling to ExecDir which is capable of specifying environment variables,
so that we can invoke `git` with GIT_INDEX_FILE, GIT_DIR, etc..

For go-gitea#258
@typeless
Copy link
Contributor Author

typeless commented Nov 27, 2016 •
edited
Loading

My bad. The second commit was intended to be in another PR. I am trying to rollback it.

@tboerger
Copy link
Member

So need to wait for drone again

@tboerger tboerger merged commit bc59b8a into go-gitea:master Nov 27, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@typeless @lunny @thibaultmeyer @tboerger