Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some animation bugs #27287

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Fix some animation bugs #27287

merged 5 commits into from
Sep 27, 2023

Conversation

wxiaoguang
Copy link
Contributor

Fix #27286
Replace #27279

@wxiaoguang wxiaoguang added the backport/v1.21 This PR should be backported to Gitea 1.21 label Sep 26, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Sep 26, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 26, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2023
@github-actions github-actions bot added the topic/ui Change the appearance of the Gitea UI label Sep 26, 2023
@wxiaoguang wxiaoguang mentioned this pull request Sep 26, 2023
Closed
@CaiCandong
Copy link
Member

CaiCandong commented Sep 26, 2023 •
edited
Loading

Wait, I think a checkbox is more reasonable to fix #27286
When I select a long name branch, it looks weird
image

Like this repo, the branch name is too long to show.
https://try.gitea.io/olblak/updatecli-mirror/graph

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Sep 26, 2023 •
edited
Loading

Wait, I think a checkbox is more reasonable to fix #27286
When I select a long name branch, it looks weird

That's a different problem. Your suggestion is to refactor the "branch selector" to a new UI component.

My PR is just to fix the broken dropdown display.

@silverwind
Copy link
Member

Long branch name can be truncated to like 500px, but it's unrelated to the issue, yes.

@CaiCandong
Copy link
Member

Ok, I got it.

silverwind
silverwind approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 27, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 27, 2023
@lunny lunny enabled auto-merge (squash) September 27, 2023 01:11
@lunny lunny merged commit 6967c13 into go-gitea:main Sep 27, 2023
@GiteaBot GiteaBot mentioned this pull request Sep 27, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 27, 2023
@wxiaoguang @GiteaBot
Fix some animation bugs (go-gitea#27287)
c37f579 
Fix go-gitea#27286
Replace go-gitea#27279
@wxiaoguang wxiaoguang deleted the fix-ani branch September 27, 2023 01:16
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 27, 2023
wxiaoguang added a commit that referenced this pull request Sep 27, 2023
@GiteaBot @wxiaoguang
Fix some animation bugs (#27287) (#27294)
fee8522 
Backport #27287

Fix #27286
Replace #27279

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 28, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
7bf3179 
* giteaoffical/main: (22 commits)
  Fix review UI (go-gitea#27322)
  Improve issue history dialog and make poster can delete their own history (go-gitea#27323)
  Improve branch list UI (go-gitea#27319)
  doctor: delete action entries without existing user (go-gitea#27292)
  fix orphan check for deleted branch (go-gitea#27310)
  make writing main test easier (go-gitea#27270)
  [skip ci] Updated translations via Crowdin
  Fix protected branch icon location (go-gitea#26576)
  move the `gitea admin` subcommands into separate files (go-gitea#27307)
  Fix chinese translation (go-gitea#27296)
  bump bleve (go-gitea#27300)
  Redefine the meaning of column is_active to make Actions Registration Token generation easier (go-gitea#27143)
  Use vitest globals (go-gitea#27102)
  Fix divider in subscription page (go-gitea#27298)
  Fix yaml test (go-gitea#27297)
  Enable production source maps for index.js, fix CSS sourcemaps (go-gitea#27291)
  Fix some animation bugs (go-gitea#27287)
  Add missed return to actions view fetch (go-gitea#27289)
  Fix more yaml lint errors (go-gitea#27284)
  Fix incorrect change from go-gitea#27231 (go-gitea#27275)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Weird UI behavior when selecting multi-branch in commit graph page
5 participants
@wxiaoguang @CaiCandong @silverwind @lunny @GiteaBot