-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve multiple strings in en-US locale #26213
Merged
Merged
Changes from 15 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
8d85589
Improve multiple strings in en-US locale
n0toose 6c03a40
Fix mistake, improve wording in two other strings
n0toose 5edb210
Just one improvement.
n0toose 49658e0
Update options/locale/locale_en-US.ini
n0toose 5512eff
Update options/locale/locale_en-US.ini
n0toose 3fe1184
Update options/locale/locale_en-US.ini
n0toose 3c72fe7
Update options/locale/locale_en-US.ini
n0toose 68fb2d3
Update options/locale/locale_en-US.ini
n0toose be23fc7
Update options/locale/locale_en-US.ini
n0toose ac34d7e
Update options/locale/locale_en-US.ini
n0toose 5fbaaf5
Update options/locale/locale_en-US.ini
n0toose 79de8c2
Update options/locale/locale_en-US.ini
n0toose 120be75
Update options/locale/locale_en-US.ini
n0toose 8fc9f79
Address comments by wxiaoguang
n0toose 73740e9
Put Gitea issues URL in parameters
delvh 6853fce
Address (some) comments by wxiaoguang
n0toose 7fa1786
Update options/locale/locale_en-US.ini
n0toose d27d5af
Remove you've in detailed, formal-sounding strings
n0toose 251ddfa
Actually add that new parameter to template
n0toose 32ce04c
Make purpose of primary email much more explicit
n0toose 70ba259
Additional set of string improvements
n0toose 1c24fe7
Remove John Smith example entirely.
n0toose b99767b
Update options/locale/locale_en-US.ini
n0toose 7069d0d
Merge branch 'main' into string-improvements
n0toose c52d4b7
(User feedback) Add new string for Mirror Settings
n0toose 40c02f0
Fix tests
n0toose 3e8b38a
Consistent capitalization in Repository Settings
n0toose 2672036
Replace 'Re-Type' with 'Confirm'
n0toose 95ab0ed
Make 'Private' visibility's tooltip more clear
n0toose 1e61c11
Be explicit on how OAuth secrets disappear
n0toose ff67ca4
Fix Private visibility tooltip, 'that' sounds too unnatural
n0toose 85d2b9b
Address comment
n0toose 607941d
Merge branch 'main' into string-improvements
n0toose 0a04406
Add periods in signing notice in PRs
n0toose d51db06
Undo parameter thing
n0toose da755b4
Do not repeat 'How do I mirror repositories?' title
n0toose 3903db3
Improve 'Packages' menu
n0toose 60eb6d2
Use email description in profile section as well
n0toose 9a85c89
Improve language around what hidden emails do
n0toose faf68dc
Address delvh's comments
n0toose 0b87ed3
Fix inconsistency in Visibility options
n0toose 98440f2
Make owner.settings.chef.keypair.description more explicit
n0toose 696975d
Fix grammar error in oauth2_application_remove_description
n0toose c29d08c
Merge branch 'main' into string-improvements
GiteaBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's better to change the key to avoid other languages rendering error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the feedback, but I'm really not sure as to how I can address this. Do you want me to revert my changes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He meant that outdated translations which do not have the arguments may error because we pass more arguments in than the translation accepts, but I think this is something the translation function could gracefully handle.
Too much arguments should be gracefully ignored, only too few arguments is a real problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it may not even be an issue because as far as I understand, the change will invalidate all existing translations, so they should fallback to english until translated again, and no further changes are necessary here.