Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multiple strings in en-US locale #26213

Merged
merged 44 commits into from
Aug 8, 2023
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
8d85589
Improve multiple strings in en-US locale
n0toose Jul 28, 2023
6c03a40
Fix mistake, improve wording in two other strings
n0toose Jul 29, 2023
5edb210
Just one improvement.
n0toose Jul 29, 2023
49658e0
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
5512eff
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
3fe1184
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
3c72fe7
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
68fb2d3
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
be23fc7
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
ac34d7e
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
5fbaaf5
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
79de8c2
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
120be75
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
8fc9f79
Address comments by wxiaoguang
n0toose Jul 29, 2023
73740e9
Put Gitea issues URL in parameters
delvh Jul 29, 2023
6853fce
Address (some) comments by wxiaoguang
n0toose Jul 29, 2023
7fa1786
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
d27d5af
Remove you've in detailed, formal-sounding strings
n0toose Jul 29, 2023
251ddfa
Actually add that new parameter to template
n0toose Jul 29, 2023
32ce04c
Make purpose of primary email much more explicit
n0toose Jul 29, 2023
70ba259
Additional set of string improvements
n0toose Jul 29, 2023
1c24fe7
Remove John Smith example entirely.
n0toose Jul 29, 2023
b99767b
Update options/locale/locale_en-US.ini
n0toose Jul 29, 2023
7069d0d
Merge branch 'main' into string-improvements
n0toose Jul 29, 2023
c52d4b7
(User feedback) Add new string for Mirror Settings
n0toose Jul 29, 2023
40c02f0
Fix tests
n0toose Jul 29, 2023
3e8b38a
Consistent capitalization in Repository Settings
n0toose Jul 29, 2023
2672036
Replace 'Re-Type' with 'Confirm'
n0toose Jul 29, 2023
95ab0ed
Make 'Private' visibility's tooltip more clear
n0toose Jul 30, 2023
1e61c11
Be explicit on how OAuth secrets disappear
n0toose Jul 30, 2023
ff67ca4
Fix Private visibility tooltip, 'that' sounds too unnatural
n0toose Jul 30, 2023
85d2b9b
Address comment
n0toose Jul 30, 2023
607941d
Merge branch 'main' into string-improvements
n0toose Jul 31, 2023
0a04406
Add periods in signing notice in PRs
n0toose Aug 4, 2023
d51db06
Undo parameter thing
n0toose Aug 4, 2023
da755b4
Do not repeat 'How do I mirror repositories?' title
n0toose Aug 4, 2023
3903db3
Improve 'Packages' menu
n0toose Aug 5, 2023
60eb6d2
Use email description in profile section as well
n0toose Aug 6, 2023
9a85c89
Improve language around what hidden emails do
n0toose Aug 6, 2023
faf68dc
Address delvh's comments
n0toose Aug 6, 2023
0b87ed3
Fix inconsistency in Visibility options
n0toose Aug 6, 2023
98440f2
Make owner.settings.chef.keypair.description more explicit
n0toose Aug 6, 2023
696975d
Fix grammar error in oauth2_application_remove_description
n0toose Aug 8, 2023
c29d08c
Merge branch 'main' into string-improvements
GiteaBot Aug 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 23 additions & 22 deletions options/locale/locale_en-US.ini
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ username = Username
email = Email Address
password = Password
access_token = Access Token
re_type = Re-Type Password
re_type = Confirm Password
captcha = CAPTCHA
twofa = Two-Factor Authentication
twofa_scratch = Two-Factor Scratch Code
Expand Down Expand Up @@ -170,7 +170,7 @@ string.desc = Z - A

[error]
occurred = An error occurred
report_message = If you believe that this is a Gitea bug, please search for issues on <a href="%[1]s" target="_blank">GitHub</a> or open a new issue if necessary.
report_message = If you believe that this is a Gitea bug, please search for issues on <a href="%[1]s" target="_blank">%[2]s</a> or open a new issue if necessary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to change the key to avoid other languages rendering error?

Copy link
Contributor Author

@n0toose n0toose Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the feedback, but I'm really not sure as to how I can address this. Do you want me to revert my changes here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He meant that outdated translations which do not have the arguments may error because we pass more arguments in than the translation accepts, but I think this is something the translation function could gracefully handle.

Too much arguments should be gracefully ignored, only too few arguments is a real problem.

Copy link
Member

@silverwind silverwind Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it may not even be an issue because as far as I understand, the change will invalidate all existing translations, so they should fallback to english until translated again, and no further changes are necessary here.

missing_csrf = Bad Request: no CSRF token present
invalid_csrf = Bad Request: invalid CSRF token
not_found = The target couldn't be found.
Expand Down Expand Up @@ -368,7 +368,7 @@ reset_password_mail_sent_prompt = A confirmation email has been sent to <b>%s</b
active_your_account = Activate Your Account
account_activated = Account has been activated
prohibit_login = Sign In Prohibited
prohibit_login_desc = Your account is prohibited to sign in, please contact your site administrator.
prohibit_login_desc = Your account has been banned, please contact your site administrator for more information.
resent_limit_prompt = You have already requested an activation email recently. Please wait 3 minutes and try again.
has_unconfirmed_mail = Hi %s, you have an unconfirmed email address (<b>%s</b>). If you haven't received a confirmation email or need to resend a new one, please click on the button below.
resend_mail = Click here to resend your activation email
Expand All @@ -378,7 +378,7 @@ reset_password = Account Recovery
invalid_code = Your confirmation code is invalid or has expired.
invalid_password = Your password does not match the password that was used to create the account.
reset_password_helper = Recover Account
reset_password_wrong_user = You are signed in as %s, but the account recovery link is for %s
reset_password_wrong_user = You are signed in as %s, but the account recovery link is meant for %s
password_too_short = Password length cannot be less than %d characters.
non_local_account = Non-local users cannot update their password through the Gitea web interface.
verify = Verify
Expand All @@ -403,7 +403,7 @@ openid_connect_title = Connect to an existing account
openid_connect_desc = The chosen OpenID URI is unknown. Associate it with a new account here.
openid_register_title = Create new account
openid_register_desc = The chosen OpenID URI is unknown. Associate it with a new account here.
openid_signin_desc = Enter your OpenID URI. For example: https://anne.me, bob.openid.org.cn or gnusocial.net/carry.
openid_signin_desc = Enter your OpenID URI. For example: alice.openid.example.org or https://openid.example.org/alice.
disable_forgot_password_mail = Account recovery is disabled because no email is set up. Please contact your site administrator.
disable_forgot_password_mail_admin = Account recovery is only available when email is set up. Please set up email to enable account recovery.
email_domain_blacklisted = You cannot register with your email address.
Expand All @@ -413,9 +413,9 @@ authorize_application_created_by = This application was created by %s.
authorize_application_description = If you grant the access, it will be able to access and write to all your account information, including private repos and organisations.
authorize_title = Authorize "%s" to access your account?
authorization_failed = Authorization failed
authorization_failed_desc = The authorization failed because we detected an invalid request. Please contact the maintainer of the app you've tried to authorize.
authorization_failed_desc = The authorization failed because we detected an invalid request. Please contact the maintainer of the app you have tried to authorize.
sspi_auth_failed = SSPI authentication failed
password_pwned = The password you chose is on a <a target="_blank" rel="noopener noreferrer" href="https://haveibeenpwned.com/Passwords">list of stolen passwords</a> previously exposed in public data breaches. Please try again with a different password.
password_pwned = The password you chose is on a <a target="_blank" rel="noopener noreferrer" href="https://haveibeenpwned.com/Passwords">list of stolen passwords</a> previously exposed in public data breaches. Please try again with a different password and consider changing this password elsewhere too.
password_pwned_err = Could not complete request to HaveIBeenPwned

[mail]
Expand All @@ -430,7 +430,7 @@ activate_account.text_1 = Hi <b>%[1]s</b>, thanks for registering at %[2]s!
activate_account.text_2 = Please click the following link to activate your account within <b>%s</b>:

activate_email = Verify your email address
activate_email.title = %s, please verify your e-mail address
activate_email.title = %s, please verify your email address
activate_email.text = Please click the following link to verify your email address within <b>%s</b>:

register_notify = Welcome to Gitea
Expand Down Expand Up @@ -496,7 +496,7 @@ UserName = Username
RepoName = Repository name
Email = Email address
Password = Password
Retype = Re-Type Password
Retype = Confirm Password
SSHTitle = SSH key name
HttpsUrl = HTTPS URL
PayloadUrl = Payload URL
Expand Down Expand Up @@ -682,7 +682,7 @@ update_user_avatar_success = The user's avatar has been updated.
change_password = Update Password
old_password = Current Password
new_password = New Password
retype_new_password = Re-Type New Password
retype_new_password = Confirm New Password
password_incorrect = The current password is incorrect.
change_password_success = Your password has been updated. Sign in using your new password from now on.
password_change_disabled = Non-local users cannot update their password through the Gitea web interface.
Expand All @@ -691,7 +691,7 @@ emails = Email Addresses
manage_emails = Manage Email Addresses
manage_themes = Select default theme
manage_openid = Manage OpenID Addresses
email_desc = Your primary email address will be used for notifications and Git operations made using the web interface.
email_desc = Your primary email address will be used for notifications, password recovery and, provided that it is not hidden, web-based Git operations.
theme_desc = This will be your default theme across the site.
primary = Primary
activated = Activated
Expand Down Expand Up @@ -843,7 +843,7 @@ oauth2_client_id = Client ID
oauth2_client_secret = Client Secret
oauth2_regenerate_secret = Regenerate Secret
oauth2_regenerate_secret_hint = Lost your secret?
oauth2_client_secret_hint = The secret won't be visible if you revisit this page. Please save your secret.
oauth2_client_secret_hint = The secret will disappear as soon as you leave or refresh this page. Please save your secret.
oauth2_application_edit = Edit
oauth2_application_create_description = OAuth2 applications gives your third-party application access to user accounts on this instance.
oauth2_application_remove_description = Removing an OAuth2 application will prevent it to access authorized user accounts on this instance. Continue?
Expand Down Expand Up @@ -911,7 +911,7 @@ visibility.public_tooltip = Visible to everyone
visibility.limited = Limited
visibility.limited_tooltip = Visible to authenticated users only
visibility.private = Private
visibility.private_tooltip = Visible only to organization members
visibility.private_tooltip = Visible only to members of organizations that you have joined

[repo]
new_repo_helper = A repository contains all project files, including revision history. Already hosting one elsewhere? <a href="%s">Migrate repository.</a>
Expand All @@ -926,7 +926,7 @@ template_helper = Make repository a template
template_description = Template repositories let users generate new repositories with the same directory structure, files, and optional settings.
visibility = Visibility
visibility_description = Only the owner or the organization members if they have rights, will be able to see it.
visibility_helper = Make Repository Private
visibility_helper = Make repository private
visibility_helper_forced = Your site administrator forces new repositories to be private.
visibility_fork_helper = (Changing this will affect all forks.)
clone_helper = Need help cloning? Visit <a target="_blank" rel="noopener noreferrer" href="%s">Help</a>.
Expand Down Expand Up @@ -1540,7 +1540,7 @@ issues.tracking_already_started = `You have already started time tracking on <a
issues.stop_tracking = Stop Timer
issues.stop_tracking_history = `stopped working %s`
issues.cancel_tracking = Discard
issues.cancel_tracking_history = `cancelled time tracking %s`
issues.cancel_tracking_history = `canceled time tracking %s`
issues.add_time = Manually Add Time
issues.del_time = Delete this time log
issues.add_time_short = Add Time
Expand Down Expand Up @@ -1772,7 +1772,7 @@ pulls.auto_merge_has_pending_schedule = %[1]s scheduled this pull request to aut

pulls.auto_merge_cancel_schedule = Cancel auto merge
pulls.auto_merge_not_scheduled = This pull request is not scheduled to auto merge.
pulls.auto_merge_canceled_schedule = The auto merge was cancelled for this pull request.
pulls.auto_merge_canceled_schedule = The auto merge was canceled for this pull request.

pulls.auto_merge_newly_scheduled_comment = `scheduled this pull request to auto merge when all checks succeed %[1]s`
pulls.auto_merge_canceled_schedule_comment = `canceled auto merging this pull request when all checks succeed %[1]s`
Expand Down Expand Up @@ -1954,6 +1954,7 @@ settings.mirror_settings.docs.disabled_push_mirror.info = Push mirrors have been
settings.mirror_settings.docs.no_new_mirrors = Your repository is mirroring changes to or from another repository. Please keep in mind that you can't create any new mirrors at this time.
settings.mirror_settings.docs.can_still_use = Although you can't modify existing mirrors or create new ones, you may still use your existing mirror.
settings.mirror_settings.docs.pull_mirror_instructions = To set up a pull mirror, please consult:
settings.mirror_settings.docs.more_information_if_disabled = You can find out more about push and pull mirrors here:
settings.mirror_settings.docs.doc_link_title = How do I mirror repositories?
settings.mirror_settings.docs.pulling_remote_title = Pulling from a remote repository
settings.mirror_settings.mirrored_repository = Mirrored repository
Expand Down Expand Up @@ -2032,7 +2033,7 @@ settings.transfer.rejected = Repository transfer was rejected.
settings.transfer.success = Repository transfer was successful.
settings.transfer_abort = Cancel transfer
settings.transfer_abort_invalid = You cannot cancel a non existent repository transfer.
settings.transfer_abort_success = The repository transfer to %s was successfully cancelled.
settings.transfer_abort_success = The repository transfer to %s was successfully canceled.
settings.transfer_desc = Transfer this repository to a user or to an organization for which you have administrator rights.
settings.transfer_form_title = Enter the repository name as confirmation:
settings.transfer_in_progress = There is currently an ongoing transfer. Please cancel it if you will like to transfer this repository to another user.
Expand Down Expand Up @@ -2463,7 +2464,7 @@ branch.already_exists = A branch named "%s" already exists.
branch.delete_head = Delete
branch.delete = Delete Branch "%s"
branch.delete_html = Delete Branch
branch.delete_desc = Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
branch.delete_desc = Deleting a branch is permanent. Although the deleted branch may continue existing for a short time before it actually gets purged, it CANNOT be undone in most cases. Continue?
branch.deletion_success = Branch "%s" has been deleted.
branch.deletion_failed = Failed to delete branch "%s".
branch.delete_branch_has_new_commits = Branch "%s" cannot be deleted because new commits have been added after merging.
Expand Down Expand Up @@ -2632,7 +2633,7 @@ teams.all_repositories_helper = Team has access to all repositories. Selecting t
teams.all_repositories_read_permission_desc = This team grants <strong>Read</strong> access to <strong>all repositories</strong>: members can view and clone repositories.
teams.all_repositories_write_permission_desc = This team grants <strong>Write</strong> access to <strong>all repositories</strong>: members can read from and push to repositories.
teams.all_repositories_admin_permission_desc = This team grants <strong>Admin</strong> access to <strong>all repositories</strong>: members can read from, push to and add collaborators to repositories.
teams.invite.title = You've been invited to join team <strong>%s</strong> in organization <strong>%s</strong>.
teams.invite.title = You have been invited to join team <strong>%s</strong> in organization <strong>%s</strong>.
teams.invite.by = Invited by %s
teams.invite.description = Please click the button below to join the team.

Expand Down Expand Up @@ -2665,13 +2666,13 @@ dashboard.clean_unbind_oauth = Clean unbound OAuth connections
dashboard.clean_unbind_oauth_success = All unbound OAuth connections have been deleted.
dashboard.task.started=Started Task: %[1]s
dashboard.task.process=Task: %[1]s
dashboard.task.cancelled=Task: %[1]s cancelled: %[3]s
dashboard.task.cancelled=Task: %[1]s canceled: %[3]s
dashboard.task.error=Error in Task: %[1]s: %[3]s
dashboard.task.finished=Task: %[1]s started by %[2]s has finished
dashboard.task.unknown=Unknown task: %[1]s
dashboard.cron.started=Started Cron: %[1]s
dashboard.cron.process=Cron: %[1]s
dashboard.cron.cancelled=Cron: %[1]s cancelled: %[3]s
dashboard.cron.cancelled=Cron: %[1]s canceled: %[3]s
dashboard.cron.error=Error in Cron: %s: %[3]s
dashboard.cron.finished=Cron: %[1]s has finished
dashboard.delete_inactive_accounts = Delete all unactivated accounts
Expand Down Expand Up @@ -3424,7 +3425,7 @@ status.waiting = "Waiting"
status.running = "Running"
status.success = "Success"
status.failure = "Failure"
status.cancelled = "Cancelled"
status.cancelled = "Canceled"
status.skipped = "Skipped"
status.blocked = "Blocked"

Expand Down
2 changes: 2 additions & 0 deletions templates/repo/settings/options.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,12 @@
<a target="_blank" rel="noopener noreferrer" href="https://docs.gitea.io/en-us/usage/repo-mirror/#pulling-from-a-remote-repository">{{$.locale.Tr "repo.settings.mirror_settings.docs.doc_link_title"}}</a><br>
{{else if $onlyNewPushMirrorsEnabled}}
{{$.locale.Tr "repo.settings.mirror_settings.docs.disabled_pull_mirror.instructions"}}
{{$.locale.Tr "repo.settings.mirror_settings.docs.more_information_if_disabled"}}
<a target="_blank" rel="noopener noreferrer" href="https://docs.gitea.io/en-us/usage/repo-mirror/#pulling-from-a-remote-repository">{{$.locale.Tr "repo.settings.mirror_settings.docs.doc_link_title"}}</a><br>
{{else if $onlyNewPullMirrorsEnabled}}
{{$.locale.Tr "repo.settings.mirror_settings.docs.disabled_push_mirror.instructions"}}
{{$.locale.Tr "repo.settings.mirror_settings.docs.disabled_push_mirror.pull_mirror_warning"}}
{{$.locale.Tr "repo.settings.mirror_settings.docs.more_information_if_disabled"}}
<a target="_blank" rel="noopener noreferrer" href="https://docs.gitea.io/en-us/usage/repo-mirror/#pulling-from-a-remote-repository">{{$.locale.Tr "repo.settings.mirror_settings.docs.doc_link_title"}}</a><br><br>
{{$.locale.Tr "repo.settings.mirror_settings.docs.disabled_push_mirror.info"}}
{{if $existingPushMirror}}
Expand Down
2 changes: 1 addition & 1 deletion templates/status/500.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
{{end}}
<div class="center gt-mt-5">
{{if or .SignedUser.IsAdmin .ShowFooterVersion}}<p>{{.locale.Tr "admin.config.app_ver"}}: {{AppVer}}</p>{{end}}
{{if .SignedUser.IsAdmin}}<p>{{.locale.Tr "error.report_message" "https://github.com/go-gitea/gitea/issues" | Str2html}}</p>{{end}}
{{if .SignedUser.IsAdmin}}<p>{{.locale.Tr "error.report_message" "https://github.com/go-gitea/gitea/issues" "GitHub" | Str2html}}</p>{{end}}
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/example.test.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ test('Test Register Form', async ({page}, workerInfo) => {
// Make sure we routed to the home page. Else login failed.
await expect(page.url()).toBe(`${workerInfo.project.use.baseURL}/`);
await expect(page.locator('.dashboard-navbar span>img.ui.avatar')).toBeVisible();
await expect(page.locator('.ui.positive.message.flash-success')).toHaveText('Account was successfully created.');
await expect(page.locator('.ui.positive.message.flash-success')).toHaveText('Account was successfully created. Welcome!');

save_visual(page);
});
Expand Down