Close issue as archived/resolved/stale #25362
Conversation
|
Run |
|
Is this screenshot up to date?
For resolved, the issue state color for resolved should go purple, not red. For other states, please check on GitHub. I think stale/archived could go grey maybe. At least on GitHub "not planned" goes gray. |
|
See comment in #22793 (comment), I think we should only have two closed states and not split into archived/stale. |
| IssueClosedStatusArchived // 1 | ||
| IssueClosedStatusResolved // 2 | ||
| IssueClosedStatusStale // 3 | ||
| ) |
There was a problem hiding this comment.
As per discussion in #22793, I would request only two states: IssueClosedStatusCompleted and IssueClosedStatusNotPlanned, default is IssueClosedStatusCompleted.
| AssigneeID int64 `xorm:"-"` | ||
| Assignee *user_model.User `xorm:"-"` | ||
| IsClosed bool `xorm:"INDEX"` | ||
| ClosedStatus IssueClosedStatus `xorm:"NOT NULL DEFAULT 0"` |
There was a problem hiding this comment.
Could rename to just State so it could be used for multiple open states as well in future.
There was a problem hiding this comment.
I would strongly suggest to use two words. One-word column would cause ambiguity easily, and sometimes when the single-word is a database keyword, it causes SQL failures when the quoting is forgotten.
|
We will need to adapt issueicon.tmpl as per #22793 (comment). |
|
The only reason I can think to need an 'archived' status is if you had a bug report that couldn't be verified - you could archive it to indicate that you couldn't find it rather than that it was a bug that you didn't plan to fix. Then again, I think the difference between 'we fixed this' and 'we couldn't/didn't fix this' in complete and not planned is probably sufficient to indicate that, and anyone particularly interested could just look through the issue comments. |
|
I think it is also useful for when an issue was closed as stale, because the reporting user did not respond to a question in a long time. In that case the issue was not resolved, and I think "not planned" is not appropriate either because to me that would mean that the maintainers are not open to such a change. |
|
Why did you close the MR? Its fine if you dont want to work anymore on it, the reason I ask is to know if the feature was rejected internally, or if it can have another chance. |
|
Oh, I see. It was replaced with an other one. Writing this so that anyone who has subscribed to this issue gets to know, as references dont kick off a notification. |
replace #23522
close #22793
close #14893
Changes
closed_status.Screenshot
Close issue dropdown & button:
The comment of "close as xxx":
The default email content of the Issue:
Video record
Screen.Recording.2023-07-27.at.14.39.16.mov