golint fixed for routers #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 3.03% (diff: 100%)@@ master #208 diff @@
========================================
Files 33 33
Lines 8106 8106
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 246 246
Misses 7840 7840
Partials 20 20
|
strk
reviewed
Nov 22, 2016
| @@ -393,6 +402,7 @@ func TestWebhook(ctx *context.Context) { | |||
| } | |||
| } | |||
|
|
|||
| // DeleteWebhook delete a webhook | |||
There was a problem hiding this comment.
nitpicking: I think the phrases should be english phrases, like "DeleteWebhook deletes a web hook" (note the ending s for third person subject being the function)
|
LGTM |
|
LGTM not working ? |
|
LGTM |
|
resolved #70 |
ethantkoenig
added a commit
to ethantkoenig/gitea
that referenced
this pull request
Jul 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.