-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title attribute to dependencies in sidebar #19807
Add title attribute to dependencies in sidebar #19807
Conversation
Add the full title as the title attribute on dependencies in the sidebar. Fix go-gitea#19806 Signed-off-by: Andrew Thornton <art27@cantab.net>
I think class |
As far as I can see: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would approve, but I can't.
|
Ancient?
That, however, is a valid reason, even though I think this is one of the things, we actually don't want to style ourselves... |
Seems like inaccurate CanIUse data, the MDN table is better: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title#browser_compatibility
https://people.apache.org/~jim/NewArchitect/webrevu/tag/1998/04_03_98.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better than before, but I'd still prefer all title
usage to be refactored to use tooltip
later. It's just better UX than title
.
Signed-off-by: Andrew Thornton <art27@cantab.net>
OK done. |
* giteaofficial/main: update documents (go-gitea#19868) Only return valid stopwatches (go-gitea#19863) [skip ci] Updated translations via Crowdin Add title attribute to dependencies in sidebar (go-gitea#19807)
* Add title attribute to dependencies in sidebar Add the full title as the title attribute on dependencies in the sidebar. Fix go-gitea#19806 Signed-off-by: Andrew Thornton <art27@cantab.net> * as per silverwind Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Add the full title as the title attribute on dependencies in
the sidebar.
Fix #19806
Signed-off-by: Andrew Thornton art27@cantab.net